Approved!
Maybe this was a cache thing. I just tried it again on the 4.0 branch (with
Max's changeset) as well as legals and I cannot get it to fail. Sorry about
that. It originally failed for me in FF 1.5 but it works fine in FF1.5,
FF2.0 and IE7.
Hey, the debugger appears to run faster than I recall. Is this possible?
Thanks!
Phil
Are you saying you see this bug in legals too? I can't reproduce it
in firefox. I don't see anything in the patch that could have caused
this to break.
What browser?
On 2007-04-03, at 18:44 EDT, Philip Romanik wrote:
> Not Approved.
>
> I tested the debugger change and ran into a problem. This is true
> on legals (as well as the change set).
>
> Run this in dhtml:
>
> <canvas debug="true">
> <method event="oninit">
> Debug.write(this);
> </method>
> </canvas>
>
> Click on the '#canvas' object. An error is displayed:
>
> window.parent.$modules.lz.Debug.displayObj is not a function
>
> Phil
>
>
>
>> Change 20070402-maxcarlson-0 by [EMAIL PROTECTED] on 2007-04-02
>> 19:29:13 PDT
>> in /Users/maxcarlson/openlaszlo/4.0
>> for http://svn.openlaszlo.org/openlaszlo/branches/4.0
>>
>> Summary: Merge legals changes to 4.0.x
>>
>> New Features:
>>
>> Bugs Fixed:
>>
>> Technical Reviewer: promanik
>> QA Reviewer: jgrandy
>> Doc Reviewer: (pending)
>>
>> Documentation: I propose migrating this change (4559) to 4.0.1.
>>
>> Risk: very low -- affects format of Debug printing of anonymous
>> objects
>> Reward: people will be less likely to be fooled that the
>> representation of an anonymous object is complete when it has been
>> abbreviated.
>>
>> Also taking 4518, because it doesn't appear to be causing any
>> fallout, and 4555, even though Jim didn't get a chance to send out a
>> proposal before he left on vacation.
>>
>>
>> Release Notes:
>>
>> Details: plastik:~/openlaszlo/4.0 maxcarlson$ svn merge -r4517:4518
>> http://svn.openlaszl o.org/openlaszlo/branches/legals/
>> U WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
>> U WEB-INF/lps/server/src/org/openlaszlo/compiler/DHTMLWriter.java
>> U WEB-INF/lps/server/src/org/openlaszlo/compiler/
>> CompilationEnvironment.java
>> U WEB-INF/lps/server/src/org/openlaszlo/compiler/
>> CompilationError.java
>> U WEB-INF/lps/server/sc/src/org/openlaszlo/sc/Parser.jjt
>> U WEB-INF/lps/server/sc/src/org/openlaszlo/sc/parser/
>> ParseException.java
>> plastik:~/openlaszlo/4.0 maxcarlson$ svn merge -r4554:4555 http://
>> svn.openlaszl
>> o.org/openlaszlo/branches/legals/
>> U laszlo-explorer/explore-nav.lzx
>> plastik:~/openlaszlo/4.0 maxcarlson$ svn merge -r4558:4559 http://
>> svn.openlaszl
>> o.org/openlaszlo/branches/legals/
>> U WEB-INF/lps/lfc/debugger/platform/swf/LzDebug.as
>> U WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebug.js
>>
>>
>> Tests:
>>
>> Files:
>> M WEB-INF/lps/lfc/debugger/platform/swf/LzDebug.as
>> M WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebug.js
>> M WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/
>> DHTMLWriter.java
>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/
>> CompilationEnvironment.java
>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/
>> CompilationError.java
>> M WEB-INF/lps/server/sc/src/org/openlaszlo/sc/Parser.jjt
>> M WEB-INF/lps/server/sc/src/org/openlaszlo/sc/parser/
>> ParseException.java
>> M laszlo-explorer/explore-nav.lzx
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070402-
>> maxcarlson-0.tar
>
