We should take this.

By the way, did you search for other mis-uses of _root? Anything we can do to flag them at compile- or run-time?

jim

On Apr 6, 2007, at 11:20 PM, Max Carlson wrote:

Risks: almost nil - tiny change
Rewards: big - mousewheel works in swf again
--
Regards,
Max Carlson
OpenLaszlo.org

From: [EMAIL PROTECTED]
Date: April 6, 2007 3:32:46 PM PDT
To: [email protected]
Subject: [Laszlo-checkins] r4600 - openlaszlo/branches/legals/WEB- INF/lps/lfc/services/platform/swf
Reply-To: [email protected]


Author: max
Date: 2007-04-06 15:32:44 -0700 (Fri, 06 Apr 2007)
New Revision: 4600

Modified:
openlaszlo/branches/legals/WEB-INF/lps/lfc/services/platform/swf/ LzKeys.as
Log:
Change 20070406-maxcarlson-8 by [EMAIL PROTECTED] on 2007-04-06 10:19:58 PDT
    in /Users/maxcarlson/openlaszlo/legals-clean
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Fix LzKeys.onmousewheeldelta

New Features:

Bugs Fixed: LPP-3854 - LzKeys.onmousewheeldelta broken in swf

Technical Reviewer: promanik
QA Reviewer: jcrowley
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: LzKeys.as - shouldn't use _root.  Works now.


Tests: Run testcase from LPP-3854 in legals _under windows_ - only windows supports the mousewheel in swf :( - silly Flash!

Files:
M      WEB-INF/lps/lfc/services/platform/swf/LzKeys.as

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070406- maxcarlson-8.tar


Modified: openlaszlo/branches/legals/WEB-INF/lps/lfc/services/ platform/swf/LzKeys.as
===================================================================
--- openlaszlo/branches/legals/WEB-INF/lps/lfc/services/platform/ swf/LzKeys.as 2007-04-06 21:40:38 UTC (rev 4599) +++ openlaszlo/branches/legals/WEB-INF/lps/lfc/services/platform/ swf/LzKeys.as 2007-04-06 22:32:44 UTC (rev 4600)
@@ -548,5 +548,5 @@
     LzKeys.onmousewheeldelta.sendEvent(d);
 }
 // SWF-specific
-_root.Mouse.addListener(mouseListener);
+Mouse.addListener(mouseListener);



_______________________________________________
Laszlo-checkins mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins



Reply via email to