So Max, how about my idea of the heartbeat always watching the stage size and if it changes it can update the splash x/y (when the splash requests centering). Then we don't need any magic cutoff numbers or to expect the size to reach stability after any predictable period of time. Heck, the splash should even stay centered if the luser decides to tweak his browser size while admiring the splash screen.

On 2007-05-04, at 15:25 EDT, Pablo Kang wrote:

No dice. Copied the new lzpreloader.as file into my local 3.4 branch, rebuilt, and restarted server. Tried it on Safari and still off-centered.

pablo

On Thu, 3 May 2007, Max Carlson wrote:

It's also happening in 4.0... I bet the diff will work - the preloader hasn't changed that much...
Sarah Allen wrote:
> Hey Max,
> > The problem is happening in 3.4 -- do you think if we apply the diff to > branches/3.4, it'll work? or have trunk and legals diverged in > lzpreloader.as?
> > Thanks!
> Sarah
> > On Thu, May 3, 2007 at  6:37 PM, Max Carlson wrote:
> >> Change 20070503-maxcarlson-o by [EMAIL PROTECTED] on 2007-05-03 >> 18:30:53 PDT
>>      in /Users/maxcarlson/openlaszlo/legals-clean
>>      for http://svn.openlaszlo.org/openlaszlo/branches/legals
>>
>> Summary:  Fix splash centering
>>
>> New Features:
>>
>> Bugs Fixed: LPP-3943 - Splash off center
>>
>> Technical Reviewer: promanik
>> QA Reviewer: sallen
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details: lzpreloader.as - test to make sure the canvas size has >> stabilized before initializing the splash.
>>
>>
>> Tests: Splash positioning is solid now. Before it was often off for >> soloapps,esp. in Safari. Sarah, let me know if this helps!
>>
>> Files:
>> M      WEB-INF/lps/lfc/lzpreloader.as
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/ 20070503- >> maxcarlson-o.tar
--
Regards,
Max Carlson
OpenLaszlo.org


Reply via email to