Re: [Laszlo-dev] For Review: Change 20070505-ptw-w Summary: Don't munge canvas.{height, width}

[Max Carlson]

Approved!

P T Withington wrote:

Change 20070505-ptw-w by [EMAIL PROTECTED] on 2007-05-05 19:51:56 EDT

    in /Users/ptw/OpenLaszlo/legals-1
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Don't munge canvas.{height,width}

Bugs Fixed:

LPP-3947 'Flash and DHTM: Setting canvas width to 100% in legals results in a canvas that is 500 pixels wide'

Technical Reviewer: max (pending)
QA Reviewer: mamye (pending)

Details:
    The canvas expects to be able to do all sorts of compile-time
    parsing and manipulation of its `width` and `height` properties,
    so we can't surround them with #beginAttribute #endAttribute
    directives that are used by the Parser to give better error
    messages for attributes.

Tests:
    Bug test case works correctly.
    ant lztest

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070505-ptw-w.tar

--
Regards,
Max Carlson
OpenLaszlo.org