Change 20070529-ben-y by [EMAIL PROTECTED] on 2007-05-29 12:51:04 PDT
    in /Users/ben/src/svn/openlaszlo/branches/legals
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Make CSS mostly work in legals swf and dhtml

New Features: CSS mostly works in swf and dhtml

Bugs Fixed:
LPP-2924  Port CSS support to DHTML

Technical Reviewer: ptw (pending)
QA Reviewer: frisco (pending)
Doc Reviewer: frisco (pending)

Documentation:
This changeset makes legals support most of the CSS supported in trunk, and updates
the tests to work.

The LFC files were moved from services/platform/swf into services/ because the same code works for both swf and dhtml; it shouldn't be in platform- specific source. The other LFC code changes were guarding against examining undefined references.

The compiler (StyleSheetCompiler.java) was tweaked to emit a semicolon at a crucial
moment; the semicolon wasn't required in swf, but is crucial in dhtml.

The cssable trait does not work because user-level traits don't work in legals.
Tests that use cssable have been refactored to use style constraints.

Release Notes:
CSS mostly works.

Details:
LPP-2894 is an outstanding issue: CSS: subclasses and instances can't override style constraints set on superclass.


Tests:

http://localhost:8080/legals/test/style/metasuite.lzx? debug=true&lzr=dhtml
    four failures:
    Tests: 525 Failures: 4 Errors: 0
TestFailure: AttrNameTestCase >>> testNamedAncestor failed: Equals: expected 'i am testclass' got 'i am view' TestFailure: CSSSubclassingTestCase >>> testSubclassOverrideConstraint failed: Equals: expected 17337 got 8388736 TestFailure: CSSSubclassingTestCase >>> testSubclassOverrideConstraint failed: Equals: expected 32768 got 8388736 TestFailure: ConstraintSpeedTestCase >>> testLookupTimes failed: True: expected true got false

http://localhost:8080/legals/test/style/metasuite.lzx? debug=true&lzr=swf7
    two failures:
    Tests: 525 Failures: 2 Errors: 0
TestFailure: CSSSubclassingTestCase >>> testSubclassOverrideConstraint failed: Equals: expected 32768 got 8388736 TestFailure: CSSSubclassingTestCase >>> testSubclassOverrideConstraint failed: Equals: expected 17337 got 8388736

Files:
M      test/style/resource/resource-not-found.lzx
M      test/style/simple/simple.lzx
M      test/style/constraints/subclassing.lzx
M      test/style/constraints/constraint-test.lzx
M      test/style/neighborhood/neighborhoodclasses.lzx
M      test/style/neighborhood/thestreet.lzx
M      test/style/neighborhood/kennedy.css
M      test/style/designerview.lzx
M      test/style/descendantselector/main.lzx
M test/style/descendantselector/complex-descendant-selector- test.lzx
M      test/style/compiler/external1.css
M      test/style/compiler/external2.css
M      test/style/compiler/stylesheetelement-test.lzx
M      test/style/compiler/lib.css
M      test/style/attrselector/main.lzx
M      test/style/attrselector/name-test.lzx
A  +   WEB-INF/lps/lfc/services/LzCSSStyleSheet.js
D      WEB-INF/lps/lfc/services/platform/swf/LzCSSStyleSheet.js
D      WEB-INF/lps/lfc/services/platform/swf/LzCSSStyle.js
D      WEB-INF/lps/lfc/services/platform/swf/LzStyleSheet.js
A  +   WEB-INF/lps/lfc/services/LzCSSStyle.js
A  +   WEB-INF/lps/lfc/services/LzStyleSheet.js
M      WEB-INF/lps/lfc/services/Library.lzs
M      WEB-INF/lps/lfc/core/LzNode.lzs
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ StyleSheetCompiler.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070529-ben- y.tar


Benjamin Shine
Software Engineer, Open Laszlo / Laszlo Systems
[EMAIL PROTECTED]



Reply via email to