Approved, but a couple of changes are needed. In swf, warnings are generated because your _strokeStyle and _fillStyle cache variables aren't defined.

WARNING: ../drawview.lzx:749: reference to undefined property '_strokeStyle'
WARNING: ../drawview.lzx:696: reference to undefined property '_fillStyle'

Change 20070615-maxcarlson-j by [EMAIL PROTECTED] on 2007-06-15
16:41:33 PDT
     in /Users/maxcarlson/openlaszlo/legals-clean
     for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Fix drawview in non-IE DHTML

New Features:

Bugs Fixed: LPP-4150 - drawview broken in non-IE DHTML as of r5422

Technical Reviewer: promanik
QA Reviewer: jcrowley
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:  My attempt at initting at construct time for non-IE
browsers didn't work out - I guess not enough of the div heirarchy is
created?  Anyhow, this fixes that issue.  I also cache fill and
linestyle values to prevent extra calls to the color conversion methods.


Tests: http://localhost:8080/legals-clean/lps/components/extensions/
test/drawing.lzx?lzr=dhtml runs in non-IE DHTML browsers again.

Files:
M      lps/components/extensions/drawview.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070615-
maxcarlson-j.tar


Reply via email to