Here is a list of Ben's fixes to legals that could potentially go into 4.0.3. Ben, please review this list and respond back with which revisions you *do* want merged, and risk vs. reward for each one.

ben-available
------------------------------------------------------------------------
r5126 | ben | 2007-05-18 14:55:33 -0700 (Fri, 18 May 2007) | 28 lines
Changed paths:
   M /openlaszlo/branches/legals/lps/components/base/basetabs.lzx
   M /openlaszlo/branches/legals/test/components/lz/test-basetabs.lzx

Change 20070518-ben-m by [EMAIL PROTECTED] on 2007-05-18 13:29:37 PDT
    in /Users/ben/src/svn/openlaszlo/branches/legals

Summary: Minor fixes to tabs

New Features:

Bugs Fixed:
LPP-3999 old applyStyle code broken for tabpane
LPP-4000 error when creating tabs without tabpane

Technical Reviewer: pbr
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

(LPP-3999) The lz tabs still have some reference to old, tinted styles, which generate errors. Dealing with old style code in components is a big task, so this just patch works around the errors without really addressing the underlying situation. Now we don't try to tint the background of a tabpane if the background doesn't exist.

lps/components/base/basetabs.lzx, we shouldn't assume that there will be a 0th tab at init time; I just added a check for null, which gets rid of error (LPP-4000).

Release Notes:

Details:


Tests:
http://localhost:8080/legals/test/components/lz/test-basetabs.lzx

------------------------------------------------------------------------
r5127 | ben | 2007-05-18 14:59:25 -0700 (Fri, 18 May 2007) | 32 lines
Changed paths:
   M /openlaszlo/branches/legals/lps/components/lz/tabs.lzx

Change 20070518-ben-l by [EMAIL PROTECTED] on 2007-05-18 14:58:20 PDT
    in /Users/ben/src/svn/openlaszlo/branches/legals
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Missing file from r5126 (Minor fixes to tabs)

New Features:

Bugs Fixed:
LPP-3999 old applyStyle code broken for tabpane


Technical Reviewer: pbr
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:
(LPP-3999) The lz tabs still have some reference to old, tinted
styles, which generate errors. Dealing with old style code in
components is a big task, so this just patch works around the errors
without really addressing the underlying situation. Now we don't try
to tint the background of a tabpane if the background doesn't exist.

Release Notes:

Details:


Tests:
http://localhost:8080/legals/test/components/lz/test-basetabs.lzx

------------------------------------------------------------------------
r5128 | ben | 2007-05-18 15:47:47 -0700 (Fri, 18 May 2007) | 7 lines
Changed paths:
A /openlaszlo/branches/legals/test/components/incubator/test- roundrectbutton-simple.lzx

Change 20070518-ben-7 by [EMAIL PROTECTED] on 2007-05-18 15:46:51 PDT
    in /Users/ben/src/svn/openlaszlo/branches/legals

Summary: Simple test just for roundrectbutton, without styles

Tests:
http://localhost:8080/legals/test/components/incubator/test- roundrectbutton-simple.lzx?lzr=dhtml (error!)
------------------------------------------------------------------------
r5129 | ben | 2007-05-18 15:56:10 -0700 (Fri, 18 May 2007) | 2 lines
Changed paths:
A /openlaszlo/branches/legals/test/components/incubator/test- roundrect.lzx

little tiny test file for roundrect

------------------------------------------------------------------------
r5130 | ben | 2007-05-18 16:12:23 -0700 (Fri, 18 May 2007) | 2 lines
Changed paths:
   M /openlaszlo/branches/legals/test/drawing/drawing.lzx

Added a test case for LPP-4001, subtlety of init order in drawview.


------------------------------------------------------------------------
r5140 | ben | 2007-05-21 15:39:05 -0700 (Mon, 21 May 2007) | 34 lines
Changed paths:
   M /openlaszlo/branches/legals/lps/components/incubator/roundrect.lzx

Change 20070518-ben-y by [EMAIL PROTECTED] on 2007-05-18 16:43:22 PDT
    in /Users/ben/src/svn/openlaszlo/branches/legals

Summary: roundrect, don't try to draw before you're inited

New Features:

Bugs Fixed:
LPP-4001 roundrectbutton in dhtml

Technical Reviewer: pbr
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:
Views that inherit from drawview must not try to use the context until the
drawview is fully initialized. Thus, I added a test for isinited in the
few roundrect onfoo handlers that didn't already check isinited.

Release Notes:

Details:
LPP-4007 describes a solution for the underlying problem here, which has to do with initialization and construction order. This fix itself is sufficient to make
roundrect work.


Tests:
http://localhost:8080/legals/test/components/incubator/test- roundrect.lzx?lzr=dhtml http://localhost:8080/legals/test/components/incubator/test- roundrect.lzx http://localhost:8080/legals/test/drawing/drawing.lzx? lzr=dhtml&debug=true
http://localhost:8080/legals/test/drawing/drawing.lzx
http://localhost:8080/legals/lps/components/incubator/test/test- roundrectbutton.lzx?lzr=dhtml http://localhost:8080/legals/lps/components/incubator/test/test- roundrectbutton.lzx
------------------------------------------------------------------------
r5141 | ben | 2007-05-21 15:39:50 -0700 (Mon, 21 May 2007) | 1 line
Changed paths:
   M /openlaszlo/branches/legals/test/drawing/drawing.lzx

missing file from r5140


------------------------------------------------------------------------
r5156 | ben | 2007-05-22 12:24:24 -0700 (Tue, 22 May 2007) | 32 lines
Changed paths:
   M /openlaszlo/branches/legals/demos/lzpix/app.lzx
   M /openlaszlo/branches/legals/demos/lzpix/classes/clipboard.lzx
   M /openlaszlo/branches/legals/demos/lzpix/views/details.lzx

Change 20070521-ben-z by [EMAIL PROTECTED] on 2007-05-21 12:13:42 PDT
    in /Users/ben/src/svn/openlaszlo/branches/legals

Summary: Small fixes to lzpix to avoid spurious warnings & make clips clickable

New Features: thumbnails in clipboard are clickable

Bugs Fixed:
LPP-1813 Clicking on image in clips should put it into details view
LPP-2373 Lzpix: 'data source error' when double-clicking on an image in the grid LPP-2440 WARNING: views/details.lzx:15: reference to undefined property 'childNodes' (FF1.5 and IE6 swf only)
LPP-4008 LZPIX: error setSource called with an empty url


Technical Reviewer: crowley (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:
A few small tweaks to fix a few small bugs.

Release Notes:

Details:


Tests:
Ran lzpix in dhtml (mac firefox 2 and safari) and in swf (mac).
Ran with debug=true in firefox dhtml and swf, noted the absence of
errors and warnings


------------------------------------------------------------------------
r5157 | ben | 2007-05-22 12:52:23 -0700 (Tue, 22 May 2007) | 1 line
Changed paths:
A /openlaszlo/branches/legals/test/style/parsertricks/ embeddedhtml-test.lzx A /openlaszlo/branches/legals/test/style/parsertricks/ embeddedhtml.css

adding tests for LPP-4006, embedding html in a css stylesheet

------------------------------------------------------------------------
r5160 | ben | 2007-05-22 13:32:40 -0700 (Tue, 22 May 2007) | 1 line
Changed paths:
M /openlaszlo/branches/legals/test/style/parsertricks/ embeddedhtml-test.lzx M /openlaszlo/branches/legals/test/style/parsertricks/import- test.lzx
   M /openlaszlo/branches/legals/test/style/parsertricks/importme.css

more tests showing what works and doesn't work for markup embedded in css attribute values, re LPP-4006

------------------------------------------------------------------------
r5225 | ben | 2007-05-25 14:20:27 -0700 (Fri, 25 May 2007) | 25 lines
Changed paths:
   M /openlaszlo/branches/legals
   M /openlaszlo/branches/legals/test/style/attrselector/attrs.lzx
   M /openlaszlo/branches/legals/test/style/attrselector/main.lzx
   M /openlaszlo/branches/legals/test/style/attrselector/name-test.lzx
   D /openlaszlo/branches/legals/test/style/compiler/external-only.lzx
   A /openlaszlo/branches/legals/test/style/compiler/main.lzx
M /openlaszlo/branches/legals/test/style/compiler/ stylesheetelement-test.lzx M /openlaszlo/branches/legals/test/style/constraints/constraint- test.lzx
   A /openlaszlo/branches/legals/test/style/constraints/main.lzx
   M /openlaszlo/branches/legals/test/style/constraints/speedtest.lzx
   M /openlaszlo/branches/legals/test/style/constraints/subclassing.lzx
M /openlaszlo/branches/legals/test/style/descendantselector/ complex-descendant-selector-test.lzx M /openlaszlo/branches/legals/test/style/descendantselector/ descendantselector-test.lzx
   A /openlaszlo/branches/legals/test/style/descendantselector/main.lzx
M /openlaszlo/branches/legals/test/style/descendantselector/ simplerdescendant-test.lzx
   M /openlaszlo/branches/legals/test/style/designerview.lzx
M /openlaszlo/branches/legals/test/style/elementselector/ elementselector-test.lzx
   M /openlaszlo/branches/legals/test/style/elementselector/main.lzx
M /openlaszlo/branches/legals/test/style/elementselector/ specialclassnames-test.lzx
   D /openlaszlo/branches/legals/test/style/fake
   M /openlaszlo/branches/legals/test/style/idselector/ids.css
   M /openlaszlo/branches/legals/test/style/idselector/ids.lzx
   M /openlaszlo/branches/legals/test/style/idselector/main.lzx
   A /openlaszlo/branches/legals/test/style/metasuite.lzx
   A /openlaszlo/branches/legals/test/style/resource/main.lzx
M /openlaszlo/branches/legals/test/style/resource/resource-not- found.lzx
   M /openlaszlo/branches/legals/test/style/simple/simple.lzx
M /openlaszlo/branches/legals/test/style/specificity/ applicability.lzx M /openlaszlo/branches/legals/test/style/specificity/ newspecificity.lzx M /openlaszlo/branches/legals/test/style/specificity/specificity- tests.lzx
   A /openlaszlo/branches/legals/test/style/test.png
   M /openlaszlo/branches/legals/test/style/trait/main.lzx
   M /openlaszlo/branches/legals/test/style/urlparam/carla.css
   M /openlaszlo/branches/legals/test/style/urlparam/paramifyme.lzx

Change 20070525-ben-i by [EMAIL PROTECTED] on 2007-05-25 14:19:16 PDT
    in /Users/ben/src/svn/openlaszlo/branches/legals-clean
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Merge r5122 from trunk to legals, css test suite improvements

New Features: css test suite

Bugs Fixed: none

Technical Reviewer: none
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:
This changeset merges in r5122 from trunk, which is only changes to the tests in test/style. They now use full lzunit niceness. Each subdirectory in test/style also has a main.lzx which
tests just that subset of CSS features.
They do not yet even try to work in dhtml.

Tests:
http://localhost:8080/legals-clean/test/style/metasuite.lzx? debug=true&lzr=swf7
  currently fails silently


------------------------------------------------------------------------
  r5324 | ben | 2007-06-05 16:01:20 -0700 (Tue, 05 Jun 2007) | 24 lines
  Changed paths:
     M /openlaszlo/branches/legals/test/big_data.lzx
M /openlaszlo/branches/legals/test/connection/history/ historylib.lzx
     M /openlaszlo/branches/legals/test/connection/noauth/noauthlib.lzx
     D /openlaszlo/branches/legals/test/debug-canvas-oninit.lzx
     M /openlaszlo/branches/legals/test/dtd.lzx
     M /openlaszlo/branches/legals/test/focus.lzx
     D /openlaszlo/branches/legals/test/jum
     D /openlaszlo/branches/legals/test/jum-call.lzx
     M /openlaszlo/branches/legals/test/lazy_data.lzx
     M /openlaszlo/branches/legals/test/multiresource.lzx
     M /openlaszlo/branches/legals/test/newfonts.lzx
     D /openlaszlo/branches/legals/test/old-tests
     M /openlaszlo/branches/legals/test/pixel-text-scroll.lzx
     M /openlaszlo/branches/legals/test/platform.lzx
     M /openlaszlo/branches/legals/test/resource.lzx
     M /openlaszlo/branches/legals/test/some_data.lzx
     M /openlaszlo/branches/legals/test/traits.lzx
     D /openlaszlo/branches/legals/test/version-1-0.lzx
     D /openlaszlo/branches/legals/test/version-1-1.lzx
     M /openlaszlo/branches/legals/test/windows.lzx

  Change 20070605-ben-8 by [EMAIL PROTECTED] on 2007-06-05 15:47:41 PDT
      in /Users/ben/src/svn/openlaszlo/branches/legals/test
      for http://svn.openlaszlo.org/openlaszlo/branches/legals/test

  Summary: Make more of "ant test" work

  Bugs Fixed: PARTIAL fix for LPP-4093

  Documentation:
This change gets rid of some of the tests that are totally out of date,**
  and updates other tests in test/*.lzx top level to not use redmond
  components. This gets us part of the way through the "test" target
  in the test directory. That target does fail, but now it fails later
  than it did before this test.
  Note that these tests do not necessarily "pass"; their passing-ness
requires human inspection. This change simply makes all of these tests
  compile, which is really all that the "ant test" target is checking
  for.


  Tests:
  cd test; ant test

------------------------------------------------------------------------
  r5338 | ben | 2007-06-06 16:21:17 -0700 (Wed, 06 Jun 2007) | 1 line
  Changed paths:
     A /openlaszlo/branches/legals/test/text/cleartext.lzx

  testcase for LPP-4106 and LPP-4087


------------------------------------------------------------------------
  r5375 | ben | 2007-06-11 16:12:52 -0700 (Mon, 11 Jun 2007) | 1 line
  Changed paths:
     M /openlaszlo/branches/legals/test/style/urlparam/paramifyme.lzx

  Added a helpful description to the test.
------------------------------------------------------------------------
  r5376 | ben | 2007-06-11 16:22:36 -0700 (Mon, 11 Jun 2007) | 1 line
  Changed paths:
M /openlaszlo/branches/legals/test/style/typography/typography- test.lzx

  Fixes bug LPP-4058

Reply via email to