Not approved -- this doesn't seem to fix the bug.
I applied your changes, rebuilt, and ran the smokecheck at
http://localhost:8080/legals/test/smoke/smokecheck.lzx?lzr=dhtml
at the end I see...
ERROR: http://localhost:8080/legals/lps/includes/lfc/LFCdhtml-
debug.js:675: this.warn is not a function
which comes out to be right in the middle of LzFormat.lzs
Debug.formatToString.
On Jun 25, 2007, at 12:51 PM, P T Withington wrote:
[RESENT: Ben, would you be able to look at this soon, or should I
nominate another reviewer? I know you are probably knee-deep in
merges, maybe you want a distraction, maybe not. I'd like to check
it in so Frisco can QA -- community bug.]
Change 20070622-ptw-C by [EMAIL PROTECTED] on 2007-06-22
08:36:04 EDT
in /Users/ptw/OpenLaszlo/legals-1
for http://svn.openlaszlo.org/openlaszlo/branches/legals
Summary: Robustify Debug.format's 'write compatibility' mode
Bugs Fixed:
LPP-4141 'Debugger enabled when JavaRpc returns a String containing
'%' causes an error'
Technical Reviewer: ben (pending)
QA Reviewer: frisco (pending)
Doc Reviewer: (pending)
Details:
LzFormat: Fix type-oh that caused warning to fail (as reported in
bug). Make 'write compatibility' detector smarter. Make dealing
with unknown or incomplete control strings smarter (just echo the
unknown control). Print excess args in compatibility mode.
debugger: Added some test cases to verify that compatibility mode
works with random '%' characters.
Tests:
Test case from bug added to debugger smoke check
Files:
M test/smoke/debugger.lzl
M WEB-INF/lps/lfc/debugger/LzFormat.lzs
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070622-
ptw-C.tar
