if (all ok) {
do the right thing
} else if ($debug) {
Debug.warn("something went wrong");
}
This will make the compiler leave out the Debug.warn when debugging
is off, saving a few bytes.
[Oops. That's not what you asked. Max means:]
class LzSomething {
function setFoo (newFoo) {
this.foo = newFoo;
this.__LZsprite.setFoo(newFoo);
}
Thus LzSomething has a 'shadow' copy of the sprite `foo` value that
you can access directly, and you don't need a getter to access it.
[This is another idiom we will have to change if we ever want to use
Javarscript setters and getters instead of setAttribute (the former
should be much more efficient). But for now, you should go with the
flow.]
On 2007-06-27, at 12:10 EDT, Benjamin Shine wrote:
I don't know the pattern you're describing -- can you be a bit more
explicit, or show me an example?
On Jun 26, 2007, at 11:25 PM, Max Carlson wrote:
One more thought: do you need getters for the sprites and LzText?
Can you get away with reading properties in LzText, and make sure
they're set to the correct default values? It's faster, and
there's less code to maintain that way...
Benjamin Shine wrote:
Change 20070626-ben-3 by [EMAIL PROTECTED] on 2007-06-26 19:56:43 PDT
in /Users/ben/src/svn/openlaszlo/branches/legals
for http://svn.openlaszlo.org/openlaszlo/branches/legals
Summary: Improve default text rendering in swf8, add api for text
rendering hints
New Features: new api on LzText to control swf8 rendering parameters
Bugs Fixed:
Technical Reviewer: max (pending)
QA Reviewer: frisco (pending)
Doc Reviewer: (pending)
Documentation:
Added four new virtual attributes to LzText, each of which
control an aspect
of advanced text rendering in swf8: sharpness, thickness,
antiAliasType,
and gridFit. These attributes only have an effect in swf8; in
other runtimes,
they will quietly be no-ops. We provide set/get for each of these
new virtual
attributes, and give them good initial and default values.
Note that the default values are set such that <text>boring</
text> will
use advanced rendering and subpixel gridfitting by default, with
sharpness=0
and thickness=0.
Added capabilities for each of these text rendering attributes;
made these
capabilities true for swf, false for dhtml.
Release Notes:
Details:
Tests:
http://localhost:8080/legals/test/lztest/lztest-textstyle.lzx?
lzr=swf8&debug=true sussurate should look good but blurry. mimsy
borogroves should look not great.
"i should look bad" and "pixel gridfit" should have weird color
bands around the text
http://localhost:8080/legals/test/lztest/lztest-textstyle.lzx?
lzr=swf8&debug=true all the text should look the same
"ant doc" still works
Files:
M test/lztest/lztest-textstyle.lzx
M test/text/fonts.lzx
M WEB-INF/lps/schema/lzx.rnc
M WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
M WEB-INF/lps/lfc/kernel/swf/LzSprite.as
M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M WEB-INF/lps/lfc/views/LzText.lzs
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070626-
ben-3.tar
Benjamin Shine
Software Engineer, Open Laszlo / Laszlo Systems
[EMAIL PROTECTED]
--
Regards,
Max Carlson
OpenLaszlo.org
