Right on both counts. I've changed the code, did a review with Max,
and committed.
On Aug 3, 2007, at 1:27 PM, P T Withington wrote:
I think you could make this warning more useful by including the
node the constraint is on.
Debug.warn("There is no CSS property %s applicable to %s", pname,
node);
Looking at the code, how could it ever return undefined?
On 2007-08-03, at 16:01 EDT, Benjamin Shine wrote:
Change 20070803-ben-e by [EMAIL PROTECTED] on 2007-08-03 12:56:12 PDT
in /Users/ben/src/svn/openlaszlo/branches/wafflecone
for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
Summary: Issue a runtime warning if the result of a $style lookup
is null or undefined
New Features:
Bugs Fixed: LPP-3024 If a css'd resource is not found, an error or
warning should be issued
Technical Reviewer: max (pending)
QA Reviewer: frisco (pending)
Doc Reviewer: (pending)
Documentation:
If the developer creates a style constraint, and that constraint
evaluates to
null or undefined, they've probably made an error. Therefore, in
debug mode,
we give runtime warnings. For speed, we don't do this check when
running
in non-debug mode.
Release Notes:
Details:
Tests:
http://localhost:8080/wafflecone/test/style/resource/main.lzx
We get this warning:
WARNING: got null for CSS property lookup for nostyledefined
which is the warning requested by the bug reporter.
(Note that this test file sets itself to run in debug mode.)
Files:
M test/style/resource/resource-not-found.lzx
M WEB-INF/lps/lfc/services/LzCSSStyle.js
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070803-
ben-e.tar
