Re: [Laszlo-dev] For Review: Change 20070821-jcrowley-w Summary: Contributor Fixes: "LzAnimatorGroup" should declare the field

[Max Carlson]

Approved!

J Crowley wrote:

Change 20070821-jcrowley-w by [EMAIL PROTECTED] on 2007-08-21 19:09:27 EDT

    in /Users/jcrowley/src/svn/openlaszlo/legals-d
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Contributor Fixes: "LzAnimatorGroup" should declare the field
    "isactive" at init-time; "LzAnimatorGroup" should pass on "duration"
    to embedded animators

New Features:

Bugs Fixed: LPP-4391; LPP-4392

Technical Reviewer: pbr
QA Reviewer: max
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: Applied Andre Bargull's fixes.

Tests: Run the following test in a modified/unmodified branch:

<canvas width="500" height="500">

    <view name="tview" width="100" height="100" bgcolor="0xAA00AA">
        <animatorgroup name="hat" duration="10000" start="false"
            oninit="Debug.write(this.isactive);">

<animator attribute="x" to="${parent.parent.x + 20}" duration="7000"/>

        </animatorgroup>
    </view>

    <button onclick="tview.hat.doStart()" y="110">Go</button>
    <button onclick="tview.hat.setDuration(7000)" y="135">7000</button>
    <button onclick="tview.hat.setDuration(1000)" y="160">1000</button>

</canvas>

Files:
M      WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070821-jcrowley-w.tar

--
Regards,
Max Carlson
OpenLaszlo.org