No, I was testing on wafflecone. I'll re-review it on legals.
Are you testing these changes against legals? Philip Romanik wrote: > Conditionally approved. > > Looks like LPP-4436 broke again because an LzSprite.as change got > removed in this changeset (see getMouse()). > > Also, when I resize the window, it works great in dhtml; the window > width is 40% of the screen size. However, in swf, the window width > doesn't change when the browser window is changed. > > Otherwise, approved. > > >> 20070824-maxcarlson-s by [EMAIL PROTECTED] on 2007-08-24 16:48:32 PDT >> in /Users/maxcarlson/openlaszlo/legals-clean >> for http://svn.openlaszlo.org/openlaszlo/branches/legals >> >> Summary: Fix size of embedded DHTML apps >> >> New Features: >> >> Bugs Fixed: LPP-4579 - DHTML apps aren't sized properly when embedded >> in a page with other HTML >> >> Technical Reviewer: promanik >> QA Reviewer: jcrowley >> Doc Reviewer: (pending) >> >> Documentation: >> >> Release Notes: >> >> Details: LzSprite.as - Add capabilities.readcanvassizefromsprite >> entry. >> >> LzSprite.js - Set the container div's width and height like the >> flash embed script does. Add capabilities.readcanvassizefromsprite >> entry. Avoid clipping if capabilities.canvas_div_cannot_be_clipped >> == true. >> >> LaszloCanvas.lzs - Only read sprite properties if >> capabilities.readcanvassizefromsprite == true. >> >> embednew.js - Store the correct sizes in the propcache. >> >> Tests: See LPP-4579 >> >> Files: >> M WEB-INF/lps/lfc/kernel/swf/LzSprite.as >> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js >> M WEB-INF/lps/lfc/views/LaszloCanvas.lzs >> M lps/includes/source/embednew.js >> >> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070824- >> maxcarlson-s.tar > > -- Regards, Max Carlson OpenLaszlo.org
