I can make this only apply when calling lzsc (which means the LFC and
the Javascript lps/includes). But, I wonder if we should just not
put it in at this point?
I guess I'll send you a revised patch that only applies to the LFC
and you can measure to see if it is worth it.
On 2007-08-24, at 12:04 EDT, Max Carlson wrote:
Approved! I think we should take this, but only do the LFC for now
due to concerns about size increases.
One thing: line 738 in lps/extensions/drawview.lzx should read:
}
this.context._visible = this.visible;
}
Instead of:
}
this.context._visible = true;
}
Come to think of it, if this change only effects the LFC, you
should be able to revert all the drawview changes. Thanks!
P T Withington wrote:
[Incorporating Max's fixes, and found and fixed why smokecheck was
barfing (xpath broke silly comment I was trying to include, just
remove the comment feature -- it was a no-op anyways).
Change 20070821-ptw-l by [EMAIL PROTECTED] on 2007-08-21
06:55:15 EDT
in /Users/ptw/OpenLaszlo/wafflecone
for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
Summary: Inline setAttribute
Bugs Fixed:
LPP-4513 'Compiler Improvements to address performance'
Technical Reviewer: ptw, max
QA Reviewer: henry
Doc Reviewer: (pending)
Details:
LzContextMenu.js, LzTextSprite.js, LzInputTextSprite.js,
drawview.lzx, embednew.js, iframemanager.js - Add #pragma
"passThrough=true" to prevent div.setAttribute() from being
inlined.
CodeGenerator.java, JavascriptGenerator.java - Inline calls to
setAttribute(), unless #pragma "passThrough=true".
Tests:
All demos run as before (but faster in swf and dhtml).
smokecheck
also runs and passes now.
Files:
M WEB-INF/lps/lfc/kernel/dhtml/LzContextMenu.js
M WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
M WEB-INF/lps/server/src/org/openlaszlo/sc/
JavascriptGenerator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
M lps/components/extensions/drawview.lzx
M lps/includes/source/embednew.js
M lps/includes/source/iframemanager.js
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070821-
ptw-l.tar
--
Regards,
Max Carlson
OpenLaszlo.org
