Re: [Laszlo-dev] For Review: Change 20070827-maxcarlson-r Summary: Fix text size measurement for font styles with constraints

[Philip Romanik]

Approved.

Change 20070827-maxcarlson-r by [EMAIL PROTECTED] on 2007-08-27
13:11:25 PDT
     in /Users/maxcarlson/openlaszlo/wafflecone
     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary: Fix text size measurement for font styles with constraints

New Features:

Bugs Fixed: LPP-4571 - Text component not sized correctly when
fontsize configured via a constraint

Technical Reviewer: promanik
QA Reviewer: ben
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: LzTextSprite.as - calculate the correct line height for
single-line text in getTexfieldHeight()

LzTextSprite.js - Recalculate line heights when styles are changed in
getTexfieldHeight()

LzText.lzs - Add argument to setText() to force it to recompute the
height even if this.text is the same.  setFontName() and setFontSize
() call setText() with force == true to ensure resizing happens.

Tests: Testcase in LPP-4571 passes in swf and dhtml, http://localhost:
8080/wafflecone/test/lztest/lztest-textheight.lzx?debug=true runs as
before in swf and dhtml.

Files:
M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M      WEB-INF/lps/lfc/views/LzText.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070827-
maxcarlson-r.tar