I'll pre-approve the change.

Normally we have been reviewing them.

On 2007-09-03, at 18:39 EDT, Sarah Allen wrote:

turns out this was a bug in the test case: setselected should have been setSelected

do we need code reviews for test cases? or should I just check in the fix?

Sarah Allen wrote:
well, dataselectionmanager appears broken in wafflecone with implicit replication, is this a known issues?

I filed: http://www.openlaszlo.org/jira/browse/LPP-4638 just in case (I was running an existing test case)

Sarah Allen wrote:
Are there existing test for explicit replication? I don't see anything in /wafflecone/test/data that seems like it would cover that based on filenames...

Thanks,
Sarah




Reply via email to