Not approved. On ant clean && ant build && ant webapp.install, this actually gives me (this is the last segment of a big block of errors):

 [...]

[javac] /Users/jcrowley/src/svn/openlaszlo/trunk-c/WEB-INF/lps/ server/src/org/openlaszlo/sc/CommonGenerator.java:755: cannot find symbol [javac] symbol : method visitBinaryExpressionSequence (org.openlaszlo.sc.parser.SimpleNode,boolean,org.openlaszlo.sc.parser.Si mpleNode[])
    [javac] location: class org.openlaszlo.sc.CommonGenerator
[javac] newNode = visitBinaryExpressionSequence(node, isReferenced, children);
    [javac]                 ^
[javac] /Users/jcrowley/src/svn/openlaszlo/trunk-c/WEB-INF/lps/ server/src/org/openlaszlo/sc/CommonGenerator.java:764: cannot find symbol [javac] symbol : method visitConditionalExpression (org.openlaszlo.sc.parser.SimpleNode,boolean,org.openlaszlo.sc.parser.Si mpleNode[])
    [javac] location: class org.openlaszlo.sc.CommonGenerator
[javac] newNode = visitConditionalExpression(node, isReferenced, children);
    [javac]                 ^
[javac] /Users/jcrowley/src/svn/openlaszlo/trunk-c/WEB-INF/lps/ server/src/org/openlaszlo/sc/CommonGenerator.java:767: cannot find symbol [javac] symbol : method visitAssignmentExpression (org.openlaszlo.sc.parser.SimpleNode,boolean,org.openlaszlo.sc.parser.Si mpleNode[])
    [javac] location: class org.openlaszlo.sc.CommonGenerator
[javac] newNode = visitAssignmentExpression(node, isReferenced, children);
    [javac]                 ^
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 35 errors

BUILD FAILED
/Users/jcrowley/src/svn/openlaszlo/trunk-c/build.xml:499: The following error occurred while executing this line: /Users/jcrowley/src/svn/openlaszlo/trunk-c/WEB-INF/lps/server/ build.xml:326: Compile failed; see the compiler error output for details.

On Sep 25, 2007, at 12:32 PM, Donald Anderson wrote:

Approved!

On Sep 25, 2007, at 9:46 AM, P T Withington wrote:

[This fixes the error Josh is seeing, which is separate from the SWF generation error.]

Change 20070925-ptw-7 by [EMAIL PROTECTED] on 2007-09-25 09:38:45 EDT
    in /Users/ptw/OpenLaszlo/ringding
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix merge error in r6548

Technical Reviewer: [EMAIL PROTECTED] (pending)
QA Reviewer: jcrowley (pending)

Details:
Assertion left in common path that is supposed to only be in subclass.

Tests:
    ant clean build will now build without assertion

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070925- ptw-7.tar


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

Voice:  617-547-7881
Email:  [EMAIL PROTECTED]
WWW:    http://www.ddanderson.com


Reply via email to