Re: [Laszlo-dev] For Review: Change 20070926-jcrowley-K Summary: Local datasets do not work in datacomboboxes;

[Benjamin Shine]

Approved.

On Sep 26, 2007, at 1:54 AM, J Crowley wrote:

Change 20070926-jcrowley-K by [EMAIL PROTECTED] on 2007-09-26 04:47:38 EDT

    in /Users/jcrowley/src/svn/openlaszlo/trunk-a
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Local datasets do not work in datacomboboxes;
        datacombobox getText() missing

New Features:

Bugs Fixed: LPP-3811 - Local datasets do not work in datacomboboxes
        LPP-4468 - datacombobox getText() missing

Technical Reviewer: pbr
QA Reviewer: ben
Doc Reviewer:

Documentation:

Release Notes:

Details: Andre Bargull - LPP-3811.  Implemented his change
        to basedatacombobox.  (This was still pending review;
        ignore pending changeset 20070814-jcrowley-n.)

        Chris Bartak - LPP-4468.  Implemented his change
        to add getText() to datacombobox.

Tests: For LPP-3811:

<canvas width="100%" height="100%" debug="true" >
  <class name="inner" >
    <dataset name="dsFonts" >
      <fonts>
        <font value="Courier" >Courier</font>
        <font value="Courier-Bold" >Courier-Bold</font>
        <font value="Courier-Oblique" >Courier-Oblique</font>
        <font value="Courier-BoldOblique" >Courier-BoldOblique</font>
        <font value="Helvetica" >Helvetica</font>
      </fonts>
    </dataset>

<datacombobox itemdatapath="local:classroot.dsFonts:/fonts/ font" />

  </class>
  <inner />
</canvas>

For LPP-4468:

<canvas width="600" height="600" debug="true">

    <dataset name="items">
        <item value="item0" >item 0</item>
        <item value="item1" >item 1</item>
        <item value="item2" >item 2</item>
        <item value="item3" >item 3</item>
        <item value="item4" >item 4</item>
        <item value="item5" >item 5</item>
        <item value="item6" >item 6</item>
        <item value="item7" >item 7</item>
        <item value="item8" >item 8</item>
        <item value="item9" >item 9</item>
        <item value="item10" >item 10</item>
        <item value="item11" >item 11</item>
    </dataset>

        <view x="20" y="20" >
            <simplelayout axis="y" spacing="15"/>
        <text> local data, defaulttext="choose one.." </text>
        <datacombobox id="cbox1"
                   width="130"
                   shownitems="6"
                   defaulttext="Choose One..."
                   itemdatapath="items:/item"/>
        </view>
        
        <button onclick="Debug.write(cbox1.getText())"/>

</canvas>

Files:
M      lps/components/lz/datacombobox.lzx
M      lps/components/base/basedatacombobox.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070926- jcrowley-K.tar