Approved.

(And thanks, that threw me for a second.)

On Oct 18, 2007, at 10:57 AM, Philip Romanik wrote:

Approved!

(Josh, if you try this, it's a merge FROM wafflecone TO trunk)


Change 20071017-maxcarlson-S by [EMAIL PROTECTED] on 2007-10-17
17:18:46 PDT
     in /Users/maxcarlson/openlaszlo/trunk-clean
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Merge 'Increase size of installer window when flash installs' from trunk

New Features:

Bugs Fixed: LPP-4737

Technical Reviewer: promanik
QA Reviewer: jcrowley
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: plastik:~/openlaszlo/trunk-clean maxcarlson$ svnmerge.py merge -b -r 6509 -S ../wafflecone property 'svnmerge-integrated' set on '.'

U    lps/includes/source/flash.js

property 'svnmerge-integrated' set on '.'

From r6509 - When the flash installer runs, a small window is used (the minimum size poissible). I increased the window width/ height to 100% of the browser window. This may not be the right fix long term but it hopefully wafflecone to ship.

Tests: From r6509

1. Remove flash from the browsers: The download link is at the bottom of this pa ge: http://www.adobe.com/support/flashplayer/downloads.html. For Windows, the ex ecutable is: http://download.macromedia.com/pub/ flashplayer/current/
uninstall_fl
ash_player.exe

2. Shutdown all instances of the browser(s). Restart your browser.

3. Navigate to the page you want to run. You should get a message that flash mus t be installed. Once flash is installed, the window size should be 100% and not the default value (215x138). If the server has just started running, it may take
  some time before the app begins to run.


Files:
  M     .
M      lps/includes/source/flash.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071017-
maxcarlson-S.tar

Reply via email to