You have some duplicate declarations in the Instance interface. Maybe however you gathered them you did not distinguish between class methods and instance methods? I wonder what to do about `watch` and `unwatch`, since they are SWF-only extensions? `validateClassStructure` should be internal. And we need a way to keep this interface in sync with the implementation.

Approved.

On 2007-10-19, at 01:23 EDT, Henry Minsky wrote:

Change 20071019-hqm-4 by [EMAIL PROTECTED] on 2007-10-19 01:05:50 EDT
    in /cygdrive/c/users/hqm/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: make tag compiler check for collisions of attribute names
with properties of Object and Instance

New Features:

Bugs Fixed: LPP-4939

Technical Reviewer: ptw
QA Reviewer: dda
Doc Reviewer:

Documentation:

Release Notes:

Details:

Make "Object" the base class for the LFC ViewSchema.
Declare "Instance" in lfc.lzx, and declare attributes on it.
(technically a couple of them belong to 'Object', not Instance:  call,
apply) but it doesn't really
matter.


Tests:

smokecheck
compile webtop lzmail and compare script output previous to this change

Files:
M      WEB-INF/lps/schema/lfc.lzx
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewSchema.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071019- hqm-4.tar


--
Henry Minsky
Software Architect
[EMAIL PROTECTED]

Reply via email to