Hrmm, good point. I'll not check this in, and will instead file a bug on Henry's schema replacement (unless there already is one), and resolve this one as a duplicate of it.

On Oct 18, 2007, at 5:44 PM, P T Withington wrote:

[Adding Henry]

Is this really the right fix? You are changing the API of roundrect if you change the type from 'size' to 'number'. I am pretty sure technical marketing will tell you you can't do that.

The real bug here is that Henry's schema-replacement project broke 'size' as a type. We need to fix that.

On 2007-10-18, at 15:11 EDT, J Crowley wrote:

Change 20071018-jcrowley-R by [EMAIL PROTECTED] on 2007-10-18 15:05:08 EDT
    in /Users/jcrowley/src/svn/openlaszlo/trunk-a
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: roundrect.lzx will not compile

New Features:

Bugs Fixed: LPP-4928 - roundrect.lzx will not compile

Technical Reviewer: ben
QA Reviewer: max
Doc Reviewer:

Documentation:

Release Notes:

Details: Changed instances of "size" to "number", since "size"
        is not an acceptable attribute type.  (I didn't
        implement the other change about the comment having
        three dashes, because if I'm not mistaken, the three
        dashes in comments are part of the documentation.  It
        still compiled for me.)

Tests: Run the following:

<canvas>
    <include href="incubator/roundrect.lzx"/>
    <roundrect width="100" height="100" bgcolor="#00FF00"/>
</canvas>

Note that it actually compiles now.

Files:
M      lps/components/incubator/roundrect.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071018- jcrowley-R.tar


Reply via email to