Maybe we should also add an accessor for the nodeType to LzDatapointer.
So instead of "dp.p.nodeType", just write "dp.getNodeType()" (with dp instanceof LzDatapointer). Reason: we've got getter-methods for almost everything, but "nodeType" and therefore we should stay consistent in our coding-practice (=> http://forum.openlaszlo.org/showthread.php?t=11064).

Approved, if you add to the documentation how to test nodeType as Andr? pointed out (by comparing to the constant).

On 2007-11-02, at 14:35 EDT, Henry Minsky wrote:

> Change 20071102-hqm-4 by [EMAIL PROTECTED] on 2007-11-02 14:33:22 EDT
>    in /cygdrive/c/users/hqm/openlaszlo/trunk2
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary:  set nodeName of text nodes to '#text', per spec
>
> New Features:
>
> Bugs Fixed: LPP-4724
>
> Technical Reviewer: pbr
> QA Reviewer: ptw
> Doc Reviewer: jsundman
>
> Documentation:
>
> The nodeName of a LzTextNode now returns '#text', not null as it > used to.
> Please update any code.
> The recommended way to determine of a node is a Text Node is to ask
> for it's nodeType,
> not it's nodeName.
>
>
> Release Notes:
>
> Details:
>
>
> Tests:
>
> see bug report
>
>
> Files:
> M      WEB-INF/lps/lfc/data/LzDataText.lzs
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071102-hqm-4.tar
>
>
> -- > Henry Minsky
> Software Architect
> [EMAIL PROTECTED]

Reply via email to