Approved.

May you add nulling out the "dataRequest" field on destroy, so this won't leak either. ["this.dataRequest = null;"]

On 11/21/2007 7:08 PM, Henry Minsky wrote:
Change 20071121-hqm-8 by [EMAIL PROTECTED] on 2007-11-21 12:47:42 EST
   in /cygdrive/c/users/hqm/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk <http://svn.openlaszlo.org/openlaszlo/trunk>

Summary: clear childNodes array when destroying an LzDataset

New Features:

Bugs Fixed: LPP-4688

Technical Reviewer: andre
QA Reviewer: pbr
Doc Reviewer:

Documentation:

Release Notes:

Details:
This addresses one of the issues in the bug report, but does not address adding any delegates to listen for an 'ondestroy' event to allow references
from other nodes to be nulled out.


Tests:

smokecheck
lfc/data/alldata.lzx

Files:
M      WEB-INF/lps/lfc/data/LzDataset.lzs


Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071121-hqm-8.tar <http://svn.openlaszlo.org/openlaszlo/patches/20071121-hqm-8.tar>

Reply via email to