Approved.
Change 20071206-dda-3 by <mailto:[EMAIL PROTECTED]>[EMAIL PROTECTED]
on 2007-12-06 19:04:34 EST
in /Users/dda/laszlo/src/svn/openlaszlo/trunk
for
<http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Separate ParseTreePrinter into its own class
New Features: none, only code reorg to make life easier for development.
Bugs Fixed: LPP-4786
Technical Reviewer: ptw
QA Reviewer: promanik
Doc Reviewer: (pending)
Documentation: none
Release Notes: none
Details:
ParseTreePrinter was an inner class within the Compiler class.
In SWF9, we
separated this class to its own file to make it more natural
to subclass.
However, ongoing maintenance and additions to Compiler.ParseTreePrinter
are troublesome to merge when they appear in devildog (each change
must be hand merged).
The diff associated with this review is messier than it could be -
since it shows all the changes made to this file after it was copied
into the tree from devildog. I essentially removed anything
SWF9 related - the new ParseTreePrinter.java is pretty much
an exact copy of Compiler.ParseTreePrinter with only minor
formatting changes and a couple changes needed to make
it compile. It might be better to compare (old)
Compiler.ParseTreePrinter
with (new) ParseTreePrinter.java using 'diff -b'.
Tests:
Ran smokecheck
Compared the binaries for the LFCs before and after this change.
Files:
M WEB-INF/lps/server/src/org/openlaszlo/sc/ReferenceCollector.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
A + WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/LibraryWriter.java
Changeset:
<http://svn.openlaszlo.org/openlaszlo/patches/20071206->http://svn.openlaszlo.org/openlaszlo/patches/20071206-
dda-3.tar
--
Don Anderson
Java/C/C++, Berkeley DB, systems consultant
Voice: 617-547-7881
Email: <mailto:[EMAIL PROTECTED]>[EMAIL PROTECTED]
WWW: <http://www.ddanderson.com>http://www.ddanderson.com
