OK I am going to back out of this change. The handling of $datapath in
the LzReplicationManager
is more complicated than I thought, and I just haven't been able to
combine $datapath and datapath successfully.
On Jan 22, 2008 4:28 PM, André Bargull <[EMAIL PROTECTED]> wrote:
> I guess you need to stay with "__LZmakeDatapath", but extend it to
> except a string as in "setDatapath".
> Reason: people may have overriden "setDatapath" and they only expect a
> string as the argument, not an object. It's a public API!
> Example: "components/base/baselistitem.lzx"
>
>
> And one minor change in "LzReplicationManager#construct(..)":
> this.cloneAttrs.datapath = LzNode._ignoreAttribute;//delete this line
> this.cloneAttrs.datapath = { name : 'datapath' };
>
>
>
> On 1/10/2008 3:55 AM, Henry Minsky wrote:
> > This is a proposed change to merge the behavior of $datapath and
> > datapath in node construction.
> >
> > I'm not sure if this covers all the cases yet, but it would seem to
> > simplify things considerably, so
> > we only have to worry about looking at the 'datapath' attribute when
> > constructing the datapath
> > at node construct/replicate time.
> >
> >
> >
> > Change 20080109-hqm-2 by [EMAIL PROTECTED] on 2008-01-09 21:44:10 EST
> > in /cygdrive/c/users/hqm/openlaszlo/trunk
> > for http://svn.openlaszlo.org/openlaszlo/trunk
> >
> > Summary: make <datapath> tag and datapath attribute more equivalent
> >
> > New Features:
> >
> > Bugs Fixed: LPP-4386, LPP-5193
> >
> > Technical Reviewer: andre
> > QA Reviewer: ptw, max
> > Doc Reviewer: (pending)
> >
> > Documentation:
> >
> > Release Notes:
> >
> > Details:
> >
> > remove the generating and use of $datapath attribute. Overload the
> > "datapath" attribute
> > to take either a string or an "initobj" hash table to specify a
> > <datapath> element.
> >
> > Move the setDatapath setter to be an early setter, to emulate curent
> > behavior of
> > the setter for $datapath (__LZmakeDatapath)
> >
> >
> > Tests:
> >
> > test/lfc/data/alldata.lzx
> > calendar demo
> > amazon demo
> > test case double_datapath.lzx in LPP 5193
> >
> > Files:
> > M WEB-INF/lps/lfc/core/LzNode.lzs
> > M WEB-INF/lps/lfc/data/LzReplicationManager.lzs
> > M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
> >
> >
> >
> >
> >
> >
> >
> > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080109-hqm-2.tar
> >
> > --
> > Henry Minsky
> > Software Architect
> > [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
> >
>
>
--
Henry Minsky
Software Architect
[EMAIL PROTECTED]
