The standard-components look okay, but some parts of LzView/LzText may need to be changed.

example: (input)text and password:
<canvas>
<inputtext bgcolor="gray" password="${true|false}" /><!-- just any value, actually don't care-->
</canvas>

Was:
no password inputtext

Now:
password inputtext

Note:
you couldn't and you still cannot constrain the password-attribute, but the test in "LzText#construct(..)" gives now a different result. The same goes for the font-attributes, the multiline-attr, the pattern, the advanced-font things etc.


On 2/15/2008 10:16 AM, André Bargull wrote:
Improvements:

LzText:
this.text = (!('text' in args) || args.text == null || args.text instanceof LzConstraintExpr || args.text instanceof LzInitExpr) ? "" : args.text;
this.text = (!('text' in args) || args.text == null || args.text instanceof LzInitExpr) ? "" : args.text;
(LzConstraintExpr subclasses LzInitExpr.)

LzState:
if "parent._instanceAttrs" is null or undefined (you test for that, don't you?), you can actually skip the whole loop.

The changes in LzText and drawview make me wonder whether we need to update other construct-methods, too?!

Change 20080214-maxcarlson-B by [EMAIL PROTECTED] on 2008-02-14 19:19:09 PST
     in /Users/maxcarlson/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix states and constrained text in DHTML, fix drawview

New Features:

Bugs Fixed: LPP-1587 'ECMA4: Compile LZX declarations as JS declarations' (partial)

Technical Reviewer: promanik
QA Reviewer: ptw
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: LzTextSprite.js - Don't store args.text from construct.

LzText.lzs - Default to '' in construct() when args.text instanceof LzConstraintExpr || args.text instanceof LzInitExpr

LzState.lzs - More safety checking when unpacking args.

drawview.lzx - Don't use args.height/width/clip to init drawview.

Tests: drawview works again, no warnings under IE when reloading pages. Constrained text works again.

Files:
M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M      WEB-INF/lps/lfc/views/LzText.lzs
M      WEB-INF/lps/lfc/helpers/LzState.lzs
M      lps/components/extensions/drawview.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080214-maxcarlson-B.tar

--

Reply via email to