[Sorry for not responding sooner. This got lost in my inbox while I was on vacation.]

I'm going to reject this change, given the recent discussion on laszlo- user about how states should operate. The consensus there seems to be that if a state provides a new value for an attribute in its parent, then any parent constraint should be removed when the state is applied, but that it should _not_ be restored when the state is removed.

If someone really wants to toggle between two different constraints, I guess they would have to use two states.

On 2008-02-17, at 11:25 EST, André Bargull wrote:

Change 20080217-bargull-4 by [EMAIL PROTECTED] on 2008-02-17 17:14:37
in /home/Admin/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: LzState#remove and constraints

New Features:

Bugs Fixed: LPP-5444 - "Now we've got Super-Constraints!"

Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
When we're re-applying the constraints in LzState#remove(), we must not call the constraint-methods!


Tests:

Files:
M WEB-INF/lps/lfc/core/LzNode.lzs
M WEB-INF/lps/lfc/helpers/LzState.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080217-bargull-4.tar



Reply via email to