Given the comment from Adam, since LzParams is not supposed to treat any keywords specially, I think we are better off making it not be a node. If anyone was using it as a node, they will have to adapt. (It would be really bad if keys like 'name' or 'id' got sidetracked and not entered as a param!)

On 2008-03-12, at 18:02 EDT, André Bargull wrote:

Some thoughts:
- What if people use "new lz.params()", so accessing the LzParam through the "lz"-namespace? That won't work anymore. - and less important: Maybe someone expects the LzParam object to be in the subnodes-Array of its parent. Same goes for id and all other LzNode stuff. Even if I don't think anyone actually uses these aspects of LzNode for LzParam....

I think the original idea must have been to make it available in LZX
somehow, but that was before
my time..


There is one usage I saw in LzDataset

function getParams (){
   if (this.params == null) {
       new LzParam ( this , { name : "params" } );
   }

   return this.params;
}

But that could just be made to bind "this.params = new LzParam()", I
don't see anywhere that  depends on it
being an actual LzNode for any reason.

On Wed, Mar 12, 2008 at 4:32 PM, P T Withington <ptw at pobox.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev >> wrote:
>/ That sounds like the right thing.  Unless someone is expecting to
/>/  write <param>...</param> why would it be a node?
/>/
/>/
/>/
/>/  On 2008-03-12, at 16:11 EDT, Henry Minsky wrote:
/>/
/>/ > LzParam is this hash-table-like thing that was supposed to keep track />/ > of query args for HTTP requests for datasets; it was supposed to be
/>/  > able to
/>/ > keep them case-sensitively, even in swf5, and keep multiple values, />/ > etc. I don't see why it is a LzNode though, but there might be one
/>/  > or two places that still expect it to be.
/>/  >
/>/ > I think we ought to make it stop subclassing LzNode, but i had better />/ > check the callers I can find to make sure nobody is depending on that.
/>/  >
/>/  >
/>/  >
/>/ > On Wed, Mar 12, 2008 at 4:05 PM, P T Withington <ptw at mac.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev>> wrote: />/ >> Hah. Well that is not going to work if LzParam inherits from LzNode.
/>/  >> What is LzParam and does it need to be a Node?
/>/  >>
/>/  >>
/>/  >>
/>/  >> On 2008-03-12, at 15:44 EDT, Henry Minsky wrote:
/>/  >>
/>/  >>> from adam...
/>/  >>>
/>/  >>>
/>/  >>> ---------- Forwarded message ----------
/>/ >>> From: Adam Wolff <adam at elasticprocess.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev >>
/>/  >>> Date: Wed, Mar 12, 2008 at 3:38 PM
/>/  >>> Subject: Re: Fwd: [Laszlo-dev] Any idea what this line from
/>/  >>> LzParam is
/>/  >>> supposed to mean?
/>/ >>> To: Henry Minsky <henry.minsky at gmail.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev >>
/>/  >>>
/>/  >>>
/>/ >>> I forget the mechanism, but the idea is to make sure that LzParam
/>/  >>> doesn't
/>/  >>> treat keywords like "parent" or "name" specially.
/>/  >>>
/>/  >>> A
/>/  >>>
/>/  >>>
/>/  >>> On Wed, March 12, 2008 12:21 pm, Henry Minsky wrote:
/>/  >>>> ??
/>/  >>>>
/>/  >>>>
/>/  >>>>
/>/  >>>> ---------- Forwarded message ----------
/>/ >>>> From: P T Withington <ptw at pobox.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev >>
/>/  >>>> Date: Wed, Mar 12, 2008 at 2:39 PM
/>/ >>>> Subject: [Laszlo-dev] Any idea what this line from LzParam is
/>/  >>>> supposed to
/>/ >>>> mean? To: Laszlo-dev bug reporting <laszlo-dev at openlaszlo.org <http://www.openlaszlo.org/mailman/listinfo/laszlo- dev>>
/>/  >>>>
/>/  >>>>
/>/  >>>>
/>/  >>>> //undefine all setters but name and id
/>/  >>>> setters.$hasdefaultattrs = -1;
/>/  >>>>
/>/  >>>>
/>/  >>>>
/>/  >>>>
/>/  >>>> --
/>/  >>>> Henry Minsky
/>/  >>>> Software Architect
/>/ >>>> hminsky at laszlosystems.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev >
/>/  >>>>
/>/  >>>
/>/  >>>
/>/  >>>
/>/  >>>
/>/  >>>
/>/  >>> --
/>/  >>> Henry Minsky
/>/  >>> Software Architect
/>/ >>> hminsky at laszlosystems.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev >
/>/  >>
/>/  >>
/>/  >
/>/  >
/>/  >
/>/  > --
/>/  > Henry Minsky
/>/  > Software Architect
/>/ > hminsky at laszlosystems.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev >
/>/
/>/
/


--
Henry Minsky
Software Architect
hminsky at laszlosystems.com <http://www.openlaszlo.org/mailman/listinfo/laszlo-dev >



Reply via email to