Why renaming LzSelectionManager and LzDataSelectionManager to
LzSelectionmanager and LzDataselectionmanager? I thought all LFC classes
(should) have camel-case, like LzLazyReplicationManager,
LzResizeReplicationManager, LzModeManager, LzAnimatorGroup, etc.
Hmm, the "$lzc$set_"-prefix doesn't really convince me, that looks like
it should be actually handled by the compiler or wherever..
What do other languages do to declare setters?
How smart is the compiler, does it recognize setters, if not, using
setAttribute would be really expensive:
setAttribute("foo", 1) -> calls $lzc$set_foo(1) -> and this calls
finally setFoo(1)
Why deprecating these methods in LzAnimator(Group)?
LzAnimatorGroup: setTarget, setDuration, setStart
LzAnimator: setMotion, setTo
") ?
- var tooltip = this.getAttribute("tooltip_obj");
+ var tooltip = this.tooltipbj");
"hisetAttribute"?
- var keyID =
component.getAttribute(this.getAttribute("component_identifier"));
- var msg = this.getAttribute("messageMap")[keyID];
+ var keyID = component.hisetAttribute("component_identifier"));
+ var msg = this.messageMap[keyID];
missing $debug
var p = this.immediateparent;
+ var anc = [];
while (p != canvas) {
- if (p instanceof basecomponent) {
+ anc.push(p)
+ if (p instanceof lz.basecomponent) {
this._parentcomponent = p;
break;
}
p = p.immediateparent;
}
+ if (! this._parentcomponent) {
+ Debug.debug("No parent for %s in %s", this, anc);
+ }
+
BTW, poor reviewers, GLHF :o)
Change 20080313-ptw-5 by [EMAIL PROTECTED] on 2008-03-13
10:54:50 EDT
in /Users/ptw/OpenLaszlo/ringding-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: LZX classes as JS2 classes
New Features: The tag compiler now emits LZX classes as JS2 class
declarations
Bugs Fixed:
LPP-1587 'ECMA4: Compile LZX declarations as JS declarations' (partial)
Technical Reviewer: [EMAIL PROTECTED] (pending)
QA Reviewer: [EMAIL PROTECTED] (pending)
Doc Reviewer: [EMAIL PROTECTED] (pending)
Documentation: TBD
Release Notes: TBD
Details:
Highlights: The tag compiler now emits user classes as a JS2
class declaration. UserClass.lzs is dead. Setters are now just
methods on a class with a distinctive name, so the whole setters
table inheritance mechanism is gone. Early/delayed setters is a
private protocol between LzNode and LzView. All classes have a
uniorm 'namespace' naming scheme: $lzc$class_<tagname>, old LFC
class names are maintained for compatibility, but there are NO
global class names any more. All user code will have to be
updated to use lz.<tagname> to address classes for `new` or
`instanceof` tests.
[Details TBD]
Tests:
smokecheck has one failure regarding placement, amazon fails in
dhtml, I suspect due to the placement problem.
Files:
M test/smoke/regression.lzl
M test/smoke/all_setters.lzl
M test/smoke/getters-setters.lzl
M test/attribute-override-1.lzx
M WEB-INF/lps/lfc/kernel/swf/LzLibrary.lzs
M WEB-INF/lps/lfc/kernel/dhtml/LzLibrary.js
M WEB-INF/lps/lfc/kernel/swf9/LzLibrary.lzs
M WEB-INF/lps/lfc/kernel/LzLibraryCleanup.lzs
M WEB-INF/lps/lfc/core/LzNode.lzs
M WEB-INF/lps/lfc/core/UserClass.lzs
M WEB-INF/lps/lfc/views/LzInputText.lzs
M WEB-INF/lps/lfc/views/LzScript.lzs
M WEB-INF/lps/lfc/views/LzText.lzs
M WEB-INF/lps/lfc/views/LaszloView.lzs
M WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M WEB-INF/lps/lfc/helpers/LzDataSelectionManager.lzs
M WEB-INF/lps/lfc/helpers/LzCommand.lzs
M WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs
M WEB-INF/lps/lfc/helpers/LzState.lzs
M WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
M WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
M WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
M WEB-INF/lps/lfc/data/LzReplicationManager.lzs
M WEB-INF/lps/lfc/data/platform/swf/LzConnectionDatasource.lzs
M WEB-INF/lps/lfc/data/platform/swf/LzConnection.lzs
M WEB-INF/lps/lfc/data/LzDatapointer.lzs
M WEB-INF/lps/lfc/data/LzDataText.lzs
M WEB-INF/lps/lfc/data/LzDataRequest.lzs
M WEB-INF/lps/lfc/data/LzDataElement.lzs
M WEB-INF/lps/lfc/data/LzDataProvider.lzs
M WEB-INF/lps/lfc/data/LzDataset.lzs
M WEB-INF/lps/lfc/data/LzDatapath.lzs
M WEB-INF/lps/lfc/data/LzHTTPDatasource.lzs
M WEB-INF/lps/lfc/data/LzParam.lzs
M WEB-INF/lps/lfc/compiler/Class.lzs
M WEB-INF/lps/server/src/org/openlaszlo/xml/internal/Schema.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/ScriptCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/ScriptClass.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
M lps/components/queens-charts/barchart.lzx
M lps/components/queens-charts/linechart.lzx
M lps/components/queens-charts/shared/dataseries.lzx
M lps/components/queens-charts/shared/basechartbacking.lzx
M lps/components/queens-charts/shared/basechart.lzx
M lps/components/queens-charts/shared/wholepie.lzx
M lps/components/queens-charts/shared/legend.lzx
M lps/components/queens-charts/piechart.lzx
M lps/components/rpc/rpc.lzx
M lps/components/rpc/xmlrpc.lzx
M lps/components/debugger/newcontent.lzx
M lps/components/debugger/scrollingtext.lzx
M lps/components/charts/common/dataseries.lzx
M lps/components/charts/common/chart.lzx
M lps/components/incubator/fisheye_lib.lzx
M lps/components/incubator/gradientview.lzx
M lps/components/incubator/autocompletecombobox.lzx
M lps/components/incubator/test/tooltipmanager-test.lzx
M lps/components/incubator/opttree/opttree.lzx
M lps/components/incubator/colorpicker.lzx
M lps/components/incubator/tooltipmanager.lzx
M lps/components/incubator/baseradio.lzx
M lps/components/incubator/rich-text/test/richtexteditarea-test.lzx
M lps/components/incubator/rich-text/linkdialog.lzx
M lps/components/incubator/validators/validatingForm.lzx
M lps/components/incubator/validators/basevalidator.lzx
M lps/components/incubator/uploader/example/test-fileuploadlist.lzx
M lps/components/incubator/uploader/example/test-
multiplefileupload.lzx
M lps/components/incubator/uploader/multiplefileupload.lzx
M lps/components/extensions/av/mediastream.lzx
M lps/components/extensions/av/videoview.lzx
M lps/components/extensions/av/rtmpconnection.lzx
M lps/components/base/basescrollbar.lzx
M lps/components/base/swatchview.lzx
M lps/components/base/basetree.lzx
M lps/components/base/componentmanager.lzx
M lps/components/base/basecomponent.lzx
M lps/components/base/basetabslider.lzx
M lps/components/base/baselist.lzx
M lps/components/base/basegrid.lzx
M lps/components/base/basetabs.lzx
M lps/components/base/basedatacombobox.lzx
M lps/components/base/style.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080313-ptw-5.tar
