Approved!
As I pointed out in my comment to Henry, there is still some work to
be done to make states work in the new scheme... <gah!>
The startup time increase is a little worrying. This is probably due
to the way applyArgs has to check for the presence of setters now, but
we should be able to recover this in the next phase of changes (where
the compiler will write a custom applyArgs for each class, eliminating
the general loop).
On 2008-03-13, at 19:28 EDT, Max Carlson wrote:
Change 20080313-maxcarlson-i by [EMAIL PROTECTED] on 2008-03-13
16:23:47 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Update LzPix, calendar and explore-nav to work with new
class system
New Features:
Bugs Fixed: LPP-1587 'ECMA4: Compile LZX declarations as JS
declarations' (partial)
Technical Reviewer: [EMAIL PROTECTED]
QA Reviewer: ptw
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: Very straightforward - just added lz. for class lookups. I
feel much better about committing Tucker's changes to trunk now! I
also had to patch LzState:
--- WEB-INF/lps/lfc/helpers/LzState.lzs (revision 8253)
+++ WEB-INF/lps/lfc/helpers/LzState.lzs (working copy)
@@ -410,7 +410,7 @@
//create a setter for this method; by definition
attributes that
//the state has a setter for are handled by the state
- this.__LZaddSetter( mname , '__LZsetProperty' );
+ //this.__LZaddSetter( mname , '__LZsetProperty' );
} else {
var arrtopush = pardels;
}
Tests: LzPix, explorer and calendar all run in DHTML now with
Tucker's latest changeset. Note that the calendar now takes 2x to
start up in swf8 - 1500ms vs ~3000ms on my machine with Tucker's
changes.
All these changes should be safe to go in trunk as-is.
Files:
M lps/components/base/basetree.lzx
M laszlo-explorer/explore-nav.lzx
M demos/lzpix/classes/photocollection.lzx
M demos/lzpix/classes/clipboardinterior.lzx
M demos/calendar/calendar.lzx
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20080313-maxcarlson-i.tar
