Approved, with comment:

You could simplify findStateException:

  Set notSeen = new HashSet(complete).removeAll(set);

In fact, perhaps rather than restricting it to a single exception, you should just use whichever is shorter, the set or its complement.

On 2008-05-06, at 12:11 EDT, Donald Anderson wrote:

[ Tucker - FYI our protocol for doc tool changes is that I commit the changes at review time so Lou can easily review them. I can back out or modify changes after the fact
 based on the review].

Change 20080506-dda-3 by [EMAIL PROTECTED] on 2008-05-06 11:57:26 EDT
   in /Users/dda/laszlo/src/svn/openlaszlo/trunk-doc3
   for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Mark features available in all but one runtime as '(except RUNTIME)'

New Features:

Bugs Fixed: LPP-5905

Technical Reviewer: ptw (pending)
QA Reviewer: (pending)
Doc Reviewer: liorio (pending)

Documentation:

Release Notes:

Details:
   This cleans up the doc pages and index in cases where
   a class/method, etc. is available in all runtimes except one.
   For example, instead of listing "LzCursor (dhtml swf7 swf8)"
   we would list "LzCursor (except swf9)".  As runtimes come and
   go, this becomes more important as we add supported runtimes.

Tests:
   Built at top level: ant clean build
   Build in docs/src: ant clean reference
Verified changes in class index (e.g. LzCursor), verified changes in
   LzNode reference page which has some runtime specific methods.

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/JS2DocUtils.java
M      docs/src/reference/navbuilder/navxmlbuilder.rb

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080506-dda-3.tar



--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: [EMAIL PROTECTED]
www: http://www.ddanderson.com





Reply via email to