Have you actively started? I did the basic work on this, and noticed a bunch of things not working right. Realized that the two line numbering modes (with filename and without) really needed to be integrated - and the decision whether to emit filename or not needs to be pushed out to the end in ParseTreePrinter. I hadn't quite finished that and was planning to start again today. But if you have something already working, go for it,
I can integrate this stuff later if it's needed.

- Don

On May 16, 2008, at 10:26 AM, P T Withington wrote:

I'm re-opening 5784 to myself to work on the script-compiler part of things (passing the empty #file through). If you have any ideas or input, let me know.

On 2008-05-12, at 08:28 EDT, Donald Anderson wrote:

Approved.

I'm using LPP-5784 for all the line number issues,
and it's nexb #449.

On May 9, 2008, at 7:04 PM, P T Withington wrote:

Change 20080509-ptw-v by [EMAIL PROTECTED] on 2008-05-09 19:00:56 EDT
 in /Users/ptw/OpenLaszlo/ringding-clean/test/smoke
 for http://svn.openlaszlo.org/openlaszlo/trunk/test/smoke

Summary: Mark end of user code in tag compiler

Bugs Fixed:
Don do you have a bug for this?

Technical Reviewer: dda (pending)
QA Reviewer: hminsky (pending)

Details:
*: Output an empty source locator to mark the end of user code in the
 tag compiler

 build.xml: Make sure the compiler gets rebuilt if the Parser does,
 since the Parser constants the compiler depends on will have
 changed and the ant javac task can't tell that.

 Parser.jjt: Accept an empty #file directive.

Tests:
 lztest, smokecheck

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/sc/Function.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ ScriptElementCompiler.java M WEB-INF/lps/server/src/org/openlaszlo/compiler/ CompilerUtils.java
M      WEB-INF/lps/server/build.xml
M      WEB-INF/lps/server/sc/src/org/openlaszlo/sc/Parser.jjt

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080509-ptw-v.tar


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: [EMAIL PROTECTED]
www: http://www.ddanderson.com







--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: [EMAIL PROTECTED]
www: http://www.ddanderson.com




Reply via email to