Re: [Laszlo-dev] [UPDATED] For Review: Change 20080521-ptw-z Summary: Rename `ConstructorMap` to `lz`, don't clobber `lz` if it

[Philip Romanik]

lzpix in dhtml runs fine for me. I can't run 'ant lztest' under 
native windows because it needs bash. I tried under cygwin but it 
doesn't seem to detect when a test is finished running. I'll try again later.

What about 'ant lztest'?  Does lzpix run in DHTML?

Philip Romanik wrote:
> I didn't try the earlier changeset but I don't see Max's errors when I
> run test/lztest/lztest-node.lzx. swf9 also compiles just fine for me.
>
>
>
>> [UPDATE:  Max is seeing errors that I am not.  I am sending a new
>> version of this change on the theory that I did not have all the
>> files in the change the first time around.]
>>
>> Change 20080521-ptw-z by 
<mailto:[EMAIL PROTECTED]>[EMAIL PROTECTED]
>> <mailto:[EMAIL PROTECTED]> on 2008-05-21
>> 17:21:13 EDT
>>      in /Users/ptw/OpenLaszlo/ringding-clean
>>      for 
<http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Rename `ConstructorMap` to `lz`, don't clobber `lz` if it
>> already exists.
>>
>> Bugs Fixed:
>> LPP-6020 'DHTML compiler should check to see if window.lz hash is
>> defined before overwriting it.'
>>
>> Technical Reviewer: max (pending)
>> QA Reviewer: promanik (pending)
>>
>> Release Notes:
>>
>> Details:
>>      *: ConstructorMap -> lz
>>
>>      LzDefs: Remove private ConstructorMap.  Don't create a hash in lz
>>      if it already exists.
>>
>>      LaszloInitiator: Remove stale comment.
>>
>>      ParseTreePrinter: Define missing 'is' operator in op table,
>>      discovered while developing this patch.
>>
>> Tests:
>>      ant lztest, smokecheck
>>
>> Files:
>> M      WEB-INF/lps/lfc/core/LzNode.lzs
>> M      WEB-INF/lps/lfc/core/LzDefs.lzs
>> M      WEB-INF/lps/lfc/glue/LaszloInitiator.lzs
>> M      WEB-INF/lps/lfc/views/LzScript.lzs
>> M      WEB-INF/lps/lfc/views/LzInputText.lzs
>> M      WEB-INF/lps/lfc/views/LzText.lzs
>> M      WEB-INF/lps/lfc/views/LaszloView.lzs
>> M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs
>> M      WEB-INF/lps/lfc/helpers/LzCommand.lzs
>> M      WEB-INF/lps/lfc/helpers/LzState.lzs
>> M      WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
>> M      WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
>> M      WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
>> M      WEB-INF/lps/lfc/data/LzDatapointer.lzs
>> M      WEB-INF/lps/lfc/data/LzDataRequest.lzs
>> M      WEB-INF/lps/lfc/data/LzDataProvider.lzs
>> M      WEB-INF/lps/lfc/data/LzDataset.lzs
>> M      WEB-INF/lps/lfc/data/LzDatapath.lzs
>> M      WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java
>> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
>> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
>>
>> Changeset:
>> 
<http://svn.openlaszlo.org/openlaszlo/patches/20080521-ptw-z.tar>http://svn.openlaszlo.org/openlaszlo/patches/20080521-ptw-z.tar

--
Regards,
Max Carlson
OpenLaszlo.org