Not approved:

1) I think you should issue a warning if the color is specified as a string that is neither a CSS color spec nor a CSS color name. We want to encourage standards compliance.

2) Is the color converter hooked in to LzView#setColor and LzView#setBGColor? Shouldn't it be?

3) Rather than calling this hextoint, shouldn't it be called parseCSSColorSpec (or similar)?

On 2008-05-21, at 19:14 EDT, Max Carlson wrote:

Change 20080521-maxcarlson-B by [EMAIL PROTECTED] on 2008-05-21 16:07:48 PDT
   in /Users/maxcarlson/openlaszlo/trunk-clean
   for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix color value coercion of strings in the format '0xffffff'

Bugs Fixed: LPP-6029 - lzpix selection is black and should be yellow

Technical Reviewer: promanik
QA Reviewer: hminsky
Doc Reviewer: (pending)

Details: LzUtils - Handle strings in the format '0xffffff' - see lzpix.

LaszloCanvas.lzs - Use lz.Utils instead of LzUtils.


Tests: Selection is yellow in lzpix dhtml and swf

Files:
M      WEB-INF/lps/lfc/services/LzUtils.lzs
M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20080521-maxcarlson-B.tar

Reply via email to