Approved.

I'm going to create a new jira task to itemize the issues I'm still seeing.

- In the test app in FF2/dhtml, it takes 2 clicks to change focus between the input text boxes - In IE7/dhtml keyboard focus is lost when you move the mouse outside the input box. When you mouseover the text, all the text is selected.


Change 20080619-maxcarlson-8 by [EMAIL PROTECTED] on 2008-06-19
13:23:22 PDT
     in /Users/maxcarlson/openlaszlo/trunk-clean
for <http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk

Summary: UPDATED - Fix mouse events for inputtext with parents that have resources in IE

Bugs Fixed: LPP-5435 - DHTML: IE7: Cannot enter text in "Search" field for Amazon demo

Technical Reviewer: promanik
QA Reviewer: <mailto:[EMAIL PROTECTED]>[EMAIL PROTECTED]

Details: LzKeyboardKernel.js - Call __hideIfNotFocused instead of __hide().

LzSprite.js - Add activate_on_mouseover quirk to control global app
activation.  Avoid calling focus/blur() if an input text is focused.
Add fix_inputtext_with_parent_resource for IE to deal with the amazon search field case where an inputtext parent has a resource. Add more event cleanup in destroy(). Add sprite id to div id in debug mode.

LzTextSprite.js - Add sprite id to div id in debug mode.

LzMouseKernel.js - Only call __hideIfNotFocused() if an inputtext isn't focused. Call __hideIfNotFocused() in the correct scope.

LzInputTextSprite.js - Use a more accurate CSS name for clickable
input texts.  Use a global __handlemouse() method for mouse events.
Call select() on mouse down for __fix_inputtext_with_parent_resource
input texts. Detect input texts with resources on init() and set the __fix_inputtext_with_parent_resource flag for the instance. Call
setClickable(true/false) for __fix_inputtext_with_parent_resource
sprites to ensure onmouseenter events are caught.  Clean up
__setTextEvents() method. Prevent blurring when the mouse is over a __fix_inputtext_with_parent_resource and the field is blurred from a mouse click. Add sprite id to div id in debug mode.

Tests: SEe LPP-5435, amazon in dhtml. Note that the amazon field activates onmouseover after the first time it's been clicked - it's the best I could do!

Files:
M      WEB-INF/lps/lfc/kernel/dhtml/LzKeyboardKernel.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js

Changeset: <http://svn.openlaszlo.org/openlaszlo/patches/20080619-maxcarlson-8.tar>http://svn.openlaszlo.org/openlaszlo/patches/20080619-maxcarlson-8.tar

Reply via email to