I annotated the bug with a testcase. Thanks for the catch on the comment!
Philip Romanik wrote:
Approved!
there is a comment in LzSprite.as that I think should be removed. The
code looks like this:
//deprecated
LzSprite.prototype.loadperc = 0;
Since loadperc in the sprite is used instead of the view, the deprecated
comment should be removed.
Is there a test that exercises the events? I looked but did not find
anything.
Change 20080620-maxcarlson-q by [EMAIL PROTECTED] on 2008-06-20
16:19:49 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Clean up sprite event sending
Bugs Fixed: LPP-6463 - Sprites should use resourceevent() APIs
instead of calling setAttribute on the view that owns them
Technical Reviewer: promanik
QA Reviewer: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
Details: LzMediaLoader.lzs - Track loadperc on the sprite instead of
the view. Use resourceevent() instead of setAttribute() to send
events and set view values. Avoid sending deprecated onloadperc events.
LzMakeLoadSprite.as - Use resourceevent() instead of setAttribute() to
send events and set view values.
swf/LzSprite.as - Avoid sending deprecated events. Read
'donttrackplay' option from the view instead of the sprite.
dhtml/LzSprite.js - Use resourceevent instead of setTotalFrames() to
send ontotalframes event. Send onframesloadratio and onloadratio
events when media is loaded.
swf9/LzSprite.as - Use resourceevent instead of setTotalFrames() to
send ontotalframes event.
LaszloView.lzs - Get rid of unused properties. Add missing
onframesloadratio and onloadratio events. Update frame and
totalframes to correct defaults. Update docs. Eliminate unused
setTotalFrames() method.
Tests:
Files:
M WEB-INF/lps/lfc/kernel/swf/LzMediaLoader.lzs
M WEB-INF/lps/lfc/kernel/swf/LzMakeLoadSprite.as
M WEB-INF/lps/lfc/kernel/swf/LzSprite.as
M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
M WEB-INF/lps/lfc/views/LaszloView.lzs
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20080620-maxcarlson-q.tar
--
Regards,
Max Carlson
OpenLaszlo.org
