Approved, but I recommend making one change. In the onvisible handler
in lzproject, you can let the existing event handlers do all the work.
if(this.visible){
cvscroll.onheight.sendEvent();
cvscroll.onwidth.sendEvent();
}
Change 20080623-laszlo-2 by [EMAIL PROTECTED] on 2008-06-23 21:51:48 EDT
in /home/laszlo/src/svn/openlaszlo/trunk-liquid
for
<http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
Summary: UPDATED: Resize Window LZproject in FF2 / Firefox
New Features:
Bugs Fixed: LPP-6340 - Resize Window LZproject in FF2 / Firefox
Technical Reviewer: max
QA Reviewer: promanik
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: Added a small change that will allow one to set
the dimensions of a popup when the dimensions won't
correct themselves. (e.g. when a canvas's dimensions
in an app are set to a percentage.) This allowed me to
fix the dimensions of the window LzProject was being
opened in. We can use this mechanic in the future for
any similar apps, since the default width and height
the nav uses for popup windows aren't always appropriate
for every app.
UPDATE: I also fixed LzProject so that if it's initially
opened in a window that's smaller than the interior
content, when the interior content becomes visible, the
scrollbars will become aware of it and adjust themselves
accordingly. (The issue with the LzProject app itself
was that the scrollbars weren't adjusting properly in
relation to the interior box if the canvas started out
smaller than the interior box. That is, there should have
been a visible scrollbar with the interior box clipped
like that, and there wasn't.)
However, I think it's still a good idea to also open the
app from the laszlo-explorer nav bar at a larger vertical
size, since it makes it roughly uniform with opening it
from the button on its page in laszlo-explorer, or from the
LzProject app's own project page in /demos, where the
popup window is actually tall enough to accommodate.
Tests: Run laszlo-explorer. Click on Demos => LzProject.
The app should open in an appropriately-sized window
now, instead of one that clips the bottom. (This isn't
evident until you click "log in".)
Also, all the other app links shouldn't be affected,
since default values for dimensions are set if none are
provided, and they're exactly the same as what we'd been
using.
Files:
M laszlo-explorer/nav.xml
M laszlo-explorer/nav_dhtml.xml
M laszlo-explorer/explore-nav.lzx
M demos/lzproject/lzx/lzproject/LZProject.lzx
Changeset:
<http://svn.openlaszlo.org/openlaszlo/patches/20080623-laszlo-2.tar>http://svn.openlaszlo.org/openlaszlo/patches/20080623-laszlo-2.tar
