Not approved... With this change, I was able to reproduce the bug Phil
noted in Firefox 3 OS X DHTML by tabbing before the app had been focused
(with a click or mouseover) but only when I loaded the app from
http://localhost:8080/trunk-clean/laszlo-explorer/index.jsp?lzr=dhtml&bookmark=Welcome
and followed the steps:
Open Components from the navbar
Open Form Components from the navbar
Select Edittext example
Then hit tab.
Also, we need to move the swf/dhtml differences into the kernel somehow.
Anything outside the kernel directories should be runtime-agnostic...
Otherwise, it looks good!
André Bargull wrote:
Change 20081002-bargull-pTS by [EMAIL PROTECTED] on 2008-10-02
11:32:19
in /home/Admin/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: inputtext focus control
New Features:
Bugs Fixed: LPP-7101, LPP-7120, LPP-7119, LPP-7267
Technical Reviewer: max
QA Reviewer: promanik
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
(This is a revised changeset from a change at early october.)
LzInputSprite (swf8):
- removed "updateData" (only necessary in LzInputText)
- removed focus-check in "__handlelostFocus"
- moved "gotBlur" and "__onChanged" so it's easier to follow code
LzInputTextSprite (swf9):
- removed "updateData" (only necessary in LzInputText)
- removed focus-check in "__handlelostFocus"
- added defered execution in "__lostFocus", that way control flow is
like in swf8
- set keyboard focus in "gotFocus"
- unset keyboard focus in "gotBlur"
- use String#replace instead of split+join, because it's faster (I've
tested it!)
LzInputText:
- temporarily split "inputtextevent" into a dhtml and swf version,
because dhtml has its own issues (LPP-7113)
- "inputtextevent" (dhtml): use lz.ModeManager.rawMouseEvent to
propagate mouse-events, leave the rest untouched
- "inputtextevent" (swf): check current focus when you get an
"onblur"-event
Tests:
see bugreport
Files:
M WEB-INF/lps/lfc/kernel/swf9/LzInputTextSprite.as
M WEB-INF/lps/lfc/kernel/swf/LzInputTextSprite.as
M WEB-INF/lps/lfc/views/LzInputText.lzs
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20081002-bargull-pTS.tar
--
Regards,
Max Carlson
OpenLaszlo.org
