Change 20081110-dda-H by [EMAIL PROTECTED] on 2008-11-10 10:30:32 EST
in /Users/dda/laszlo/src/svn/openlaszlo/trunk-d
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: In schemabuilder, throw an error for invalid types
New Features:
Bugs Fixed: LPP-7231
Technical Reviewer: max (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
Changed schema builder to only permit certain types, and throw an
error otherwise,
rather than have the reader of the schema choke at runtime.
The list of accepted types is:
ID, boolean, color, css, expression, inheritableBoolean, number,
numberExpression, reference, size, string, token.
Aside:
Kept some previously working code that silently converts other
several other types (like LzNode)
to "string" in the schema. This was needed originally to get
compatibility in generating
a schema that looks like the old one (and one that is digested by
the schema reader!).
Maybe a better solution to this is to teach the readers of the
schema to
accept arbitrary types, but that goes beyond this JIRA,
and it's not clear it gives us any new functionality now.
Tests:
To see the error, recreated the original trouble by changing the
javadoc for LzNode.datapath to
/** ....
* @type lz.datanode/String
* @lzxtype datanode/string
*/
var datapath = null;
Files:
M WEB-INF/lps/server/src/org/openlaszlo/js2doc/SchemaBuilder.java
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081110-dda-H.tar
--
Don Anderson
Java/C/C++, Berkeley DB, systems consultant
voice: 617-547-7881
email: [EMAIL PROTECTED]
www: http://www.ddanderson.com
