Approved!

-----Original Message-----
From: P T Withington <[EMAIL PROTECTED]>
Sent: Friday, November 14, 2008 10:55 AM
To: [EMAIL PROTECTED]; [EMAIL PROTECTED]
Cc: [email protected]
Subject: For Review: Change 20081114-ptw-0 Summary: Add `type` to 
basevaluecomponent

Change 20081114-ptw-0 by [EMAIL PROTECTED] on 2008-11-14  
12:07:45 EST
     in /Users/ptw/OpenLaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Add `type` to basevaluecomponent

New Features:
     You can now declare the `type` of a component's value, to get it
     to interact correctly with a databinding or other text
     input/output

Bugs Fixed:
     LPP-7340  basevaluecomponent should have a 'type' so you know how  
to accept/present it

Technical Reviewer: max (pending)
QA Reviewer: [EMAIL PROTECTED] (pending)

Details:
     slider: Use presentAttribute and type to label the slider min and  
max

     baseslider: Use updateData (which uses presentAttribute and type)
     to label the thumb.

     baseformitem, basevaluecomponent: Move `type` from formitem to
     valuecomponent.

     basevaluecomponent: Add default applyData and updateData methods
     so value can be set and retrieved as a string according to its
     type.  Add dependency methods for getValue and updateData so they
     can be used in constraints.

Tests:
     Test case from bug correctly labels slider range and thumb with
     color values.

Files:
M      lps/components/lz/slider.lzx
M      lps/components/base/baseslider.lzx
M      lps/components/base/baseformitem.lzx
M      lps/components/base/basevaluecomponent.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081114-ptw-0.tar


Reply via email to