How about moving that 3-part condition into a method and calling it in the 2 (or more) places that have to make decisions about the debug window, so if we change/update the condition in the future we only have to remember to fix the one place?

On 2008-11-21, at 12:42EST, Henry Minsky wrote:

Change 20081121-hqm-x by [EMAIL PROTECTED] on 2008-11-21 12:36:01 EST
   in /Users/hqm/openlaszlo/trunk4
   for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: don't include the lps/components/debugger window library if app has remote debugging enabled

New Features:

Bugs Fixed: LPP-7631

Technical Reviewer: ptw
QA Reviewer: promanik
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

+ If lzconsoledebug is enabled, do not auto-include the components debugger window library


Tests:

compile test/hello.lzx?lzconsoledebug=true
connect to app via debug console, and see that
 +  lz.LzDebugWindow is undefined

Files:
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ ToplevelCompiler.java


Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081121-hqm-x.tar

Reply via email to