Re: [Laszlo-dev] For Review: Change 20090108-maxcarlson-V Summary: UPDATED: Fix drawview sizing, update excanvas to support IE 8

Fri, 09 Jan 2009 07:11:06 -0800

LPP-7599 works in IE8B2. I tried the testcase from LPP-7332, and it draws the outline but doesn't fill it in. 


Approved!


(I couldn't verify IE8 because their website is down. I'll test it 
when I install it.)





Change 20090108-maxcarlson-V by 
<mailto:[email protected]>[email protected] on 2009-01-08

22:03:36 PST
     in /Users/maxcarlson/openlaszlo/trunk-clean

     for 
<http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk


Summary: UPDATED: Fix drawview sizing, update excanvas to support IE 8


Bugs Fixed: LPP-7599 - Drawviews are no longer clickable, LPP-7530 - 
Update excanvas to latest version, LPP-5577 - Drawview doesn't work w/

IE8 Beta 1 DHTML


Technical Reviewer: 
<mailto:[email protected]>[email protected] QA Reviewer: promanik



Details: html-response.xslt - Force IE to IE7 emulation mode.  Note 
that this must appear immediately after the <head> tag and can't be 
dynamically inserted with javascript.


drawview.lzx - Fix braino in  $lzc$set_height()


excanvas.js - Update to r44, which adds support for IE 8.  r43 broke 
the testcase for LPP-7332 in IE - the background color of the 
background was no longer pink.  Conditionalizing changes for IE 8 on 
the browser version number fixed this for IE 6 and 7.


Tests: See LPP-7599, LPP-7332 for testcases.

Files:
M      WEB-INF/lps/templates/html-response.xslt
M      lps/components/extensions/drawview.lzx
M      lps/includes/source/excanvas.js


Changeset: 
<http://svn.openlaszlo.org/openlaszlo/patches/20090108-maxcarlson-V.tar>http://svn.openlaszlo.org/openlaszlo/patches/20090108-maxcarlson-V.tar 























					Reply via email to