Approved.

As a further improvement, you could use identity comparison instead of equality comparison when you check the views. (Just wanted to note this before Tucker does ;-)


On 1/9/2009 3:23 PM, Max Carlson wrote:
Change 20090109-maxcarlson-t by [email protected] on 2009-01-09 06:17:02 PST
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Make layout.swapSubviewOrder() and setLayoutOrder() more robust

Bugs Fixed: LPP-7573 - layout.setLayoutOrder(s1,s2) can show strange effects if s1=s2

Technical Reviewer: [email protected]
QA Reviewer: [email protected]

Details: Fix setLayoutOrder() per LPP-7573. Add warnings for swapSubviewOrder() and setLayoutOrder() when invalid view references are passed in.

Tests: See LPP-7573

Files:
M      WEB-INF/lps/lfc/controllers/LaszloLayout.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090109-maxcarlson-t.tar


Reply via email to