P T Withington wrote:
Getting closer, but I still have some issues:

1) Is this supposed to work in swf9?  Eventually?

IWFM!

2) There is no scope parameter to html/callJavascript

I removed that in favor of the path eval, per André's suggestion. It now works just like callJS().

3) I'm bothered by the use of eval when really we just want to dereference a path. There is a simple path evaluator in debugger.lzx, perhaps we should make that more generally available and use it here.

Yeah, it kind of bothered me too. I didn't want to move it to the wrapper Javascript, so I'm using eval instead...

I have a path evaluator in safeEval also - maybe we should have the debugger use that instead of keeping two different copies? I can refactor it if you'd like.


On 2009-01-14, at 23:49EST, Max Carlson wrote:

Change 20090114-maxcarlson-Q by [email protected] on 2009-01-14 20:43:59 PST
   in /Users/maxcarlson/openlaszlo/trunk-clean
   for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: UPDATED: Provide an API on the html component to call JavaScript methods in the iframe

Bugs Fixed: LPP-7595 - Provide a callMethod API on the html component to call JavaScript methods in the iframe

Technical Reviewer: [email protected], ptw
QA Reviewer: [email protected]
Doc Reviewer: liorio

Details: html.lzx - Add callJavascript() and documentation for scrollTo().

iframemanager.js - Add implementation of callJavascript().

test/html.lzx - Add tests for scrollTo() and callJavascript()

test/html-callmethod.lzx - Testcase for html method callbacks

test/html-test.html - HTML page loaded by html.lzx and html-callmethod.lzx


Tests: test-callmethod.lzx runs consistently across all runtimes.

Files:
M      lps/components/extensions/test/html.lzx
A      lps/components/extensions/test/html-test.html
A      lps/components/extensions/test/html-callmethod.lzx
M      lps/components/extensions/html.lzx
M      lps/includes/source/iframemanager.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090114-maxcarlson-Q.tar


--
Regards,
Max Carlson
OpenLaszlo.org

Reply via email to