Nice!  Approved!

But also, Henry and I were speculating: There is no reason the component debugger console (the one that sits in the app canvas in the other runtimes), shouldn't work in DHTML now too. I only made the whacky iframe-based console because the component console relied on too much stuff that did not work yet. So, I think the _real_ solution to this bug is to simply use that.

And, we also need to make a universal remote debugger console that runs standalone in a browser window and uses the flash comm channel to communicate with any laszlo app on your machine...

On 2009-01-16, at 07:51EST, Max Carlson wrote:

Change 20090116-maxcarlson-8 by [email protected] on 2009-01-16 04:46:52 PST
   in /Users/maxcarlson/openlaszlo/trunk-clean
   for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Hack to automatically add missing debugger iframe

Bugs Fixed: LPP-7306 - debugger needs to work in DHTML runtime in a custom wrapper (partial)

Technical Reviewer: ptw
QA Reviewer: mdemmon

Details: LzDebug.js - Don't attempt to create debugger iframe for rhino. Add method to explicitly create the iframe if it's missing.

rhino.js - Set navigator.platform to 'rhino' so we can easily identify it.

Tests: ant lztest works, any app with the debugger works with lzt=html. Note that the first debug message is usually lost (the html for the iframe isn't loaded yet), and there's no edit field to eval. Maynard, this is just to get you by for now...

Files:
M      WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebug.js
M      lps/utils/rhino.js

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20090116-maxcarlson-8.tar

Reply via email to