I'm not sure what the issue is in Firefox - does disabling the activate_on_mouseover quirk help with that?

Can you finish this changeset off so it works in Safari IE7 and Opera? We'll need to so something smarter onselectstart for selectable text fields - like temporarily disable the global onselectstart handler and LzMouseKernel.setMouseControl().

Otherwise we may need to defer this - I don't see it on the list here:
http://jira.openlaszlo.org/jira/secure/IssueNavigator.jspa?mode=hide&requestId=10971

Henry Minsky wrote:
That makes selectable text work for Safari, IE7, and Opera.

There is still a bug in Firefox, which was present before this patch, which is that if you select a region of text in a selectable text view, then if you move the mouse out of the text view, the selection highlight region disappears.

On Fri, May 22, 2009 at 2:25 PM, Max Carlson <[email protected] <mailto:[email protected]>> wrote:

    Change 20090522-maxcarlson-a by maxcarl...@bank on 2009-05-22
    11:17:25 PDT
       in /Users/maxcarlson/openlaszlo/trunk-clean/my-apps
       for http://svn.openlaszlo.org/openlaszlo/trunk/my-apps

    Summary: Turn text selection on in IE and Safari

    Bugs Fixed: LPP-8200 - IE DHTML: selectable="true" does not work for
    <text>

    Technical Reviewer: hminsky
    QA Reviewer: (pending)
    Doc Reviewer: (pending)

    Details: DO NOT CHECK THIS IN!

    This patch makes text selection work again in Safari.  It will take
    some work before it's ready for prime time.

    LzSprite - Don't turn on/off global mouse events - this interferes
    with selection somehow...

    LzTextSprite - Use correct CSS preperty names for KHTML/webkit, set
    to null instead of an explicit value to clear to the default when
    selectable is on.

    LzInputTextSprite - Avoid setting document.onselectstart handler -
    this also interferes with text selection.

    Tests: Toggling on selection works in Safari
    <canvas>
       <button y="40" onclick="txt.setAttribute('selectable', !
    txt.selectable)"/>
       <text name="txt">Hello Laszlo!</text>
    </canvas>

    Files:
    M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
    M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
    M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js

    Changeset:
    http://svn.openlaszlo.org/openlaszlo/patches/20090522-maxcarlson-a.tar




--
Henry Minsky
Software Architect
[email protected] <mailto:[email protected]>



--
Regards,
Max Carlson
OpenLaszlo.org

Reply via email to