Approved.

On 5/23/2009 9:34 PM, Max Carlson wrote:
Change 20090523-maxcarlson-l by maxcarl...@bank on 2009-05-23 12:30:54 PDT
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: UPDATED: Fix IE memory leaks in drawview

Bugs Fixed: LPP-7939 - Huge memory leak in IE7 on each reload of the app

Technical Reviewer: [email protected]
QA Reviewer: mdemmon

Details: Tucker fund an updated memory leak checker that pinpointed a couple of properties in drawview (one in excanvas) that were causing apps to leak.

Implemented destroy() to clean up after the canvas, added instance to LzSprite.prototype.__sprites hash so IE cleans up onbeforeunload - see LzSprite.js for more. Test to be sure __LZcanvas exists before touching it, delete self from __sprites so destroy isn't called twice.

Tests: test/extensions/drawing.lzx?lzr=dhtml&lzt=html (and webtop) show no leaks with the leak detector from M$, found at http://blogs.msdn.com/gpde/pages/javascript-memory-leak-detector.aspx

Files:
M      lps/components/extensions/drawview.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090523-maxcarlson-l.tar

Reply via email to