This change to mediastream.lzx looks like a typo:
//Debug.warite("mediastream._updateTime time=%w mode=%w
paused=%w",
// this.time, this.mode, this.paused);
Also, I'm not sure it's a good idea to remove these from the autoincludes:
videoscreen: av/videoscreen.lzx
videoslider: av/videoslider.lzx
videothumbnail: av/videothumbnail.lzx
videotogglebutton: av/videotogglebutton.lzx
Otherwise, approved!
Sarah Allen wrote:
Max -- here's the changeset again with the missing file. Sorry about that!
Change 20090602-sallen-N by [email protected] on 2009-06-02
17:47:32 PDT
in /Users/sarah/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: added independed scrubber and progress components
New Features: new components designed for use with videoview
Bugs Fixed:
Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation: components documented inline, should show up in reference
Release Notes:
Details: These compnents allow you to create your own video player that
has a different layout. I feel like the videoplayer component should be
updated to use these, but there is a feature they don't support (showing
the amount of buffer) which you can see in the YouTube demo. Since I
can't test that feature outside of the YouTube app, I can't really
implement it.
* videoview onstream event wasn't sent when stream created by URL
* mediastream: fixes to seek/pause behavior (revealed by work on the
scrubber)
Tests: test-scrubber.lzx
Files:
A test/video/test-scrubber.lzx
A test/video/resources
A test/video/resources/gradient.png
M WEB-INF/lps/misc/lzx-autoincludes.properties
M lps/components/extensions/av/mediastream.lzx
M lps/components/extensions/av/videoview.lzx
M lps/components/extensions/av/rtmpconnection.lzx
A lps/components/av/streamscrubber.lzx
A lps/components/av/streamprogress.lzx
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20090602-sallen-N.tar
http://www.ultrasaurus.com
--
Regards,
Max Carlson
OpenLaszlo.org
