Thanks for the review.  I'll revise my change and resubmit.

On 2009-06-12, at 08:11EDT, André Bargull wrote:

Why do you focus the window in "lz.embed.__dhtmlLoadScript(..)"? That helper function is used to load arbitrary script content (excanvas.js, lfc js-file and the application js-file). IMHO "lz.embed.dhtml(..)" or the LzSprite ctor would be a better place. And in LzModeManager, you need to make that change at two places: handleMouseEvent() and __LZallowInput().


Change 20090611-ptw-8 by [email protected] on 2009-06-11 16:11:19 EDT
    in /Users/ptw/OpenLaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Ensure DHTML app has focus when loaded

Bugs Fixed: LPP-8242 OL4.4 - DHTML: The UP, DOWN keys and space bar are invalid for Textlistitem on WinXP/FF3

Technical Reviewer: max (pending)
QA Reviewer: [email protected] (pending)

Details:
    LzModeManager:  Removed some platform-specific code that is no
    longer necessary now that all platforms use the same debugger.

    embednew:  Restore window focus for Firefox on Windows once the
    DHTML application is added to the DOM

Tests:
    Test case from bug

Files:
M      WEB-INF/lps/lfc/services/LzModeManager.lzs
M      lps/includes/source/embednew.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090611-ptw-8.tar



Reply via email to