Can you svn up and re-send your change? It doesn't apply cleanly to TOT. Bonus points if you add comments based on my reply to your last message (Need some help [#LPP-5447] DHTML: inputtext and clickable - OpenLaszlo Jira)...

P T Withington wrote:
[This is a work in progress that I am sending to Max so he can help finish it. Actually, anyone is welcome to pitch in!]

Change 20090722-ptw-k by [email protected] on 2009-07-22 17:43:39 EDT
    in /Users/ptw/OpenLaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Don't re-parent input text to click tree

Bugs Fixed: LPP-5447 DHTML: inputtext and clickable

Technical Reviewer: max (pending)
QA Reviewer: [email protected] (pending)

Details:
    This is just a first pass.  It doesn't reparent the input text
    sprite into the click tree, and it turns off the click tree when
    you mouse over in input element.  The test case works in Safari,
    but in Firefox, if you try to mousedown&drag to select the text in
    the input element, the entire canvas starts scrolling?

    There may be a more efficient way to disable the click tree.  I
    just discovered LzMouseKernel.setGlobalClickable which has what
    looks like a much more efficient method.

    I am sure there is a bunch of work to be done fixing up the
    accounting for __lastshown, __focusedSprite, and __lastfocus,
    whose contract I cannot figure out...

Tests:
    Test case from LPP-8334

Files:
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js


Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090722-ptw-k.tar

--
Regards,
Max Carlson
OpenLaszlo.org

Reply via email to