No, it's not just the debugger, this change seems like it causes any selectable text view to not be selectable.
On Fri, Aug 28, 2009 at 4:20 PM, P T Withington <[email protected]>wrote: > So, does the clickability of the debugger text take some completely > different path than the clickability of normal views? Maybe we are barking > up the wrong tree here. > > > On 2009-08-28, at 15:51EDT, Henry Minsky wrote: > > Yeah, I mean to look the clickdiv. Max's changes only affect the >> root canvas sprite clickdiv width and height (the code is all in "if >> (isroot) { ...}" blocks) . >> >> I was thinking maybe the "100%" >> was confusing the CSS,but I tried a canvas with an absolute width and >> height, and it >> still doesn't work. >> >> What is weird is when I comment out max's change (which makes text be >> selectable again) ) and ask for the canvas clickdiv >> width and height, they have empty string values. >> >> So I am missing something here. I thought it was going to be that the >> canvas >> clickdiv had zero size, but that doesn't seem to be the problem. >> >> lzx> canvas.sprite.__LZclickcontainerdiv.style.width >> '' >> lzx> canvas.sprite.__LZclickcontainerdiv.style.height >> '' >> lzx> canvas.sprite.__LZclickcontainerdiv >> «HTMLDivElement#0| This is the >> canvas/@sprite/@__LZclickcontainerdiv/div.lzcanvasclickd...@style="clip: >> rect(0px, 1357px, 535px, 0px); display: none;"]» >> lzx> >> >> >> >> On Fri, Aug 28, 2009 at 3:43 PM, P T Withington <[email protected] >> >wrote: >> >> Isn't it the clickdiv you need to look at, not the context div? But, if >>> the clickdiv is also 0-sized, that would explain why there is nothing to >>> click on. >>> >>> This is the clickdiv for the debugger content view: >>> >>> <div id="click/LzDebugWindow/@middle/@content/text" >>> class="lztextcontainer_click" style="z-index: 2; clip: rect(0px, 4096px, >>> 66px, 0px); left: 0px;"/> >>> >>> >>> It's clip is the right size, but it itself has no height or width. I >>> wonder if it has something to do with: >>> >>> this.quirks.size_blank_to_zero >>> >>> you could try setting that to false and see. >>> >>> >>> On 2009-08-28, at 15:08EDT, Henry Minsky wrote: >>> >>> In the sprite constructor, I see a value of zero being assigned to width >>> >>>> and >>>> height here >>>> >>>> if (quirks.fix_contextmenu) { >>>> var cxdiv = document.createElement('div'); >>>> cxdiv.className = 'lzcanvascontextdiv'; >>>> cxdiv.id = 'lzcanvascontextdiv'; >>>> root.appendChild(cxdiv); >>>> cxdiv.owner = this; >>>> cxdiv.style.width = this._w; >>>> cxdiv.style.height = this._h; >>>> Debug.info("setting cvdiv.style.width", this._w); >>>> Debug.info("setting cvdiv.style.height", this._h); >>>> this.__LZcontextcontainerdiv = cxdiv; >>>> } >>>> >>>> That prints out "0pt" for the values when it runs... >>>> >>>> On Fri, Aug 28, 2009 at 2:28 PM, Henry Minsky <[email protected] >>>> >>>>> wrote: >>>>> >>>> >>>> This regression came with changeset >>>> >>>>> >>>>> r14554 | max | 2009-08-24 21:05:44 -0400 (Mon, 24 Aug 2009) | 18 lines >>>>> >>>>> Change 20090821-maxcarlson-Y by maxcarl...@bank on 2009-08-21 17:33:09 >>>>> PDT >>>>> in /Users/maxcarlson/openlaszlo/trunk-clean >>>>> for http://svn.openlaszlo.org/openlaszlo/trunk >>>>> >>>>> Summary: Eliminate scrollbars for oversized divs >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> On Fri, Aug 28, 2009 at 1:44 PM, Henry Minsky <[email protected] >>>>> >>>>>> wrote: >>>>>> >>>>> >>>>> I'll try and locate where this regressed >>>>> >>>>>> >>>>>> >>>>>> On Fri, Aug 28, 2009 at 1:01 PM, Max Carlson <[email protected] >>>>>> >>>>>>> wrote: >>>>>>> >>>>>> >>>>>> I swear this was working the other day. What does a binary search say? >>>>>> >>>>>>> >>>>>>> -----Original Message----- >>>>>>> From: Henry Minsky <[email protected]> >>>>>>> Sent: Friday, August 28, 2009 8:58 AM >>>>>>> To: [email protected]; P. Tucker Withington <[email protected]> >>>>>>> Cc: [email protected]; [email protected] >>>>>>> Subject: Re: For Review: Change 20090827-hqm-s Summary: make context >>>>>>> menus 'hide' behavior match swf8 >>>>>>> >>>>>>> Hey Tucker, do you happen to know if something changed recently with >>>>>>> text >>>>>>> or selection that makes it not possible to select debugger messages >>>>>>> in >>>>>>> the >>>>>>> DHTML debug window? >>>>>>> >>>>>>> >>>>>>> >>>>>>> And I'm currently unable to inspect messages in the DHTML debugger >>>>>>> (at >>>>>>> least under Firefox3, tr...@14603), is that a known issue? >>>>>>> >>>>>>> >>>>>>> >>>>>>> On 8/28/2009 5:39 AM, Henry Minsky wrote: >>>>>>> Change 20090827-hqm-s by [email protected] on 2009-08-27 23:33:23 >>>>>>> EDT >>>>>>> in /Users/hqm/openlaszlo/trunk-diamond/WEB-INF/lps/lfc >>>>>>> for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc >>>>>>> >>>>>>> Summary: make context menus 'hide' behavior match swf8 >>>>>>> >>>>>>> New Features: >>>>>>> >>>>>>> Bugs Fixed: LPP-8218 >>>>>>> >>>>>>> Technical Reviewer: max >>>>>>> QA Reviewer: andre >>>>>>> Doc Reviewer: (pending) >>>>>>> >>>>>>> Documentation: >>>>>>> >>>>>>> Release Notes: >>>>>>> >>>>>>> Details: >>>>>>> >>>>>>> + Change to make a context menu hide if you mouse up or down outside >>>>>>> of >>>>>>> it >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> -- >>>>>> Henry Minsky >>>>>> Software Architect >>>>>> [email protected] >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>> -- >>>>> Henry Minsky >>>>> Software Architect >>>>> [email protected] >>>>> >>>>> >>>>> >>>>> >>>>> >>>> -- >>>> Henry Minsky >>>> Software Architect >>>> [email protected] >>>> >>>> >>> >>> >> >> -- >> Henry Minsky >> Software Architect >> [email protected] >> > > -- Henry Minsky Software Architect [email protected]
